From nobody Sat Sep 27 04:01:13 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cYYfL1G17z68g0W; Sat, 27 Sep 2025 04:01:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cYYfL01k5z3tq8; Sat, 27 Sep 2025 04:01:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758945674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t6xhxlQwyGHIkWTlG++4/l2r3gqulSbT9bKjhpHP9OY=; b=ny2R3DW5/iz9rPFWMvFO5+35ZOdnff383MXVcouNpxvOPS5FfAW3gLOjfMm9Srwn4DnFSa NnV3dqsjXZO1YNbqtF7bfbIc8BVjlbvzya6hNbXFwOSumIvnzuYSxIfL+QjtPumJPQZ/Zy xcOOF/jwGKSgD7466TASMtQE9XVET0xF6BdG7NFe0sfrC3OCWnEp20lQMuiygWkJ/nh5J9 J7yRxRcq747KYfKZ1kOVAEnKvz1FQqLHPwMiwsijQjNaB3iZrRaekI8DPZna7j93ISevm3 zz7v3BBIOmRU5qVYwZ4QjH5EzpSpNIeUKmXhqWgaboCp2fJAZPaWvoimGZwXLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758945674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t6xhxlQwyGHIkWTlG++4/l2r3gqulSbT9bKjhpHP9OY=; b=Bucz6xIVRB4T33B42woBps+yhZNb9einp1oRTpcpxEvaNcoF+obaCjfzv9Oof+xK1JQFKB xXMNf1J2tPlI49Ah5tuuLanu+Jv+H9hOE0dQA/Lx+KIyxdOB0L0+yksjME0IfzjdOtsCR7 CyG8+IwYaXjRXIUQ+v02i59h+U45tS4EjenAqAb399g825kHftglIPLC6yV9GdxBIAGCVC BEVpEiBAZtqix9koNMyv7CR2X+tLe3u4KmcKrBwD3ZZsG4tO+Fuc4wsxEN/xiL90NFVgVp IOaiNo3OwEX4I2dwmc9mt0/XZEmKpIX35iNz8PK8thYEJSEvCvANKIadsF1wUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758945674; a=rsa-sha256; cv=none; b=hXfQuhtxB88uJBAD4PThbv2l6Nq5yAiCcaW8xPv5EJcDXM+ZfvvqaYZ9uYoiO1tjKDIaP+ E7MubeqJLWwGIB/BImMlGwrPqviELUG/FDijSVQl51jzs9tvWQz21GDl6DtT+RL2ncigT3 t8vQXXaJssVr7/fEJX67bfwyvN+b4Xl8tQ+wdqqoWytXjT1HK2es6zMZIs4lMfsHtpELAJ 0ELYRGLvYaojsMaWDRfAyONJDT2D59+6zyx7Fe7XkIrz9O7z+I0VIAJ7MOwtSA0O0zGbnr NxkpUdoh6w2Hz4EsMb/+ttqzRHDWaSSBi2umDDt3yQ/52G710RrAkJUPMFSmJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cYYfK6kFXz20s; Sat, 27 Sep 2025 04:01:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58R41Dg4014937; Sat, 27 Sep 2025 04:01:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58R41Dna014934; Sat, 27 Sep 2025 04:01:13 GMT (envelope-from git) Date: Sat, 27 Sep 2025 04:01:13 GMT Message-Id: <202509270401.58R41Dna014934@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 5e395c34402d - main - vfs: stop using SDT_PROBES_ENABLED in inlined ops List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5e395c34402dc3fd5c786168442290a63ff54596 Auto-Submitted: auto-generated The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=5e395c34402dc3fd5c786168442290a63ff54596 commit 5e395c34402dc3fd5c786168442290a63ff54596 Author: Mateusz Guzik AuthorDate: 2025-09-26 20:23:49 +0000 Commit: Mateusz Guzik CommitDate: 2025-09-27 04:00:59 +0000 vfs: stop using SDT_PROBES_ENABLED in inlined ops No point after hot patching was introduced. --- sys/tools/vnode_if.awk | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/sys/tools/vnode_if.awk b/sys/tools/vnode_if.awk index 74b11e6cb27d..8e39cc2da3da 100644 --- a/sys/tools/vnode_if.awk +++ b/sys/tools/vnode_if.awk @@ -324,6 +324,10 @@ while ((getline < srcfile) > 0) { printh("extern struct vnodeop_desc " name "_desc;"); printh(""); + printh("SDT_PROBE_DECLARE(vfs, vop, " name ", entry);\n"); + printh("SDT_PROBE_DECLARE(vfs, vop, " name ", return);\n"); + printh(""); + # Print out function prototypes. printh("int " uname "_AP(struct " name "_args *);"); printh("int " uname "_APV(const struct vop_vector *vop, struct " name "_args *);"); @@ -341,10 +345,11 @@ while ((getline < srcfile) > 0) { printh("\ta.a_" args[i] " = " args[i] ";"); if (can_inline(name)) { printh("\n#if !defined(INVARIANTS) && !defined(KTR)"); - printh("\tif (!SDT_PROBES_ENABLED())"); - printh("\t\treturn (" args[0]"->v_op->"name"(&a));"); - printh("\telse"); - printh("\t\treturn (" uname "_APV("args[0]"->v_op, &a));"); + printh("\tint rc;") + printh("\tSDT_PROBE2(vfs, vop, " name ", entry, a.a_" args[0] ", &a);"); + printh("\trc = " args[0]"->v_op->"name"(&a);"); + printh("\tSDT_PROBE3(vfs, vop, " name ", return, a.a_" args[0] ", &a, rc);"); + printh("\treturn (rc);") printh("#else"); } printh("\treturn (" uname "_APV("args[0]"->v_op, &a));");