From owner-cvs-src@FreeBSD.ORG Tue Mar 7 13:33:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A70416A420; Tue, 7 Mar 2006 13:33:25 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51E6C43D53; Tue, 7 Mar 2006 13:33:20 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id CA9D251982; Tue, 7 Mar 2006 14:33:17 +0100 (CET) Received: from localhost (ana50.internetdsl.tpnet.pl [83.17.82.50]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 64F08509F1; Tue, 7 Mar 2006 14:32:51 +0100 (CET) Date: Tue, 7 Mar 2006 14:32:00 +0100 From: Pawel Jakub Dawidek To: Brian Fundakowski Feldman Message-ID: <20060307133200.GA60850@garage.freebsd.pl> References: <200602221021.k1MAL5qF031937@repoman.freebsd.org> <20060307003911.GB7835@green.homeunix.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <20060307003911.GB7835@green.homeunix.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/raid3 g_raid3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2006 13:33:25 -0000 --huq684BweRXVnRxX Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 06, 2006 at 07:39:11PM -0500, Brian Fundakowski Feldman wrote: +> On Wed, Feb 22, 2006 at 10:21:05AM +0000, Pawel Jakub Dawidek wrote: +> > pjd 2006-02-22 10:21:05 UTC +> >=20 +> > FreeBSD src repository +> >=20 +> > Modified files: +> > sys/geom/raid3 g_raid3.c=20 +> > Log: +> > Do not use bio structure after g_io_deliver(), it may not longer by = valid. +> > =20 +> > Found and fixed by: Vsevolod Lobko +> > MFC after: 3 days +>=20 +> I actually found and fixed it half a year ago... could you please +> integrate the rest of the fixes from my changes back then? A +> short-term low-memory deadlock is still possible (observed in +> practice). I think the changes also improve readability -- see +> for example the reason r1.46 existed. Heh. I own you apology. I haven't had time to work on graid3 back then and I also overlooked fix of this very problem. I integrated you fixes to my last patch which I'm planning to commit after receiving some feedback: http://people.freebsd.org/~pjd/patches/graid3.patch --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --huq684BweRXVnRxX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFEDYtQForvXbEpPzQRAoWPAJ9jK7D8+NJr4bx+zal7wa3genG0+wCg6Ray nsRORimgT2Ul620GK8bVESI= =MJAZ -----END PGP SIGNATURE----- --huq684BweRXVnRxX--