Date: Tue, 7 Mar 2006 14:32:00 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/raid3 g_raid3.c Message-ID: <20060307133200.GA60850@garage.freebsd.pl> In-Reply-To: <20060307003911.GB7835@green.homeunix.org> References: <200602221021.k1MAL5qF031937@repoman.freebsd.org> <20060307003911.GB7835@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--huq684BweRXVnRxX Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 06, 2006 at 07:39:11PM -0500, Brian Fundakowski Feldman wrote: +> On Wed, Feb 22, 2006 at 10:21:05AM +0000, Pawel Jakub Dawidek wrote: +> > pjd 2006-02-22 10:21:05 UTC +> >=20 +> > FreeBSD src repository +> >=20 +> > Modified files: +> > sys/geom/raid3 g_raid3.c=20 +> > Log: +> > Do not use bio structure after g_io_deliver(), it may not longer by = valid. +> > =20 +> > Found and fixed by: Vsevolod Lobko <seva@ip.net.ua> +> > MFC after: 3 days +>=20 +> I actually found and fixed it half a year ago... could you please +> integrate the rest of the fixes from my changes back then? A +> short-term low-memory deadlock is still possible (observed in +> practice). I think the changes also improve readability -- see +> for example the reason r1.46 existed. Heh. I own you apology. I haven't had time to work on graid3 back then and I also overlooked fix of this very problem. I integrated you fixes to my last patch which I'm planning to commit after receiving some feedback: http://people.freebsd.org/~pjd/patches/graid3.patch --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --huq684BweRXVnRxX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFEDYtQForvXbEpPzQRAoWPAJ9jK7D8+NJr4bx+zal7wa3genG0+wCg6Ray nsRORimgT2Ul620GK8bVESI= =MJAZ -----END PGP SIGNATURE----- --huq684BweRXVnRxX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060307133200.GA60850>