From owner-freebsd-hackers@FreeBSD.ORG  Thu Jul  7 10:01:27 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D5628106566B;
	Thu,  7 Jul 2011 10:01:27 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from mx0.hoeg.nl (mx0.hoeg.nl [IPv6:2a01:4f8:101:5343::aa])
	by mx1.freebsd.org (Postfix) with ESMTP id 72DFD8FC1A;
	Thu,  7 Jul 2011 10:01:27 +0000 (UTC)
Received: by mx0.hoeg.nl (Postfix, from userid 1000)
	id 664392A29125; Thu,  7 Jul 2011 12:01:23 +0200 (CEST)
Date: Thu, 7 Jul 2011 12:01:23 +0200
From: Ed Schouten <ed@80386.nl>
To: Robert Millan <rmh@debian.org>
Message-ID: <20110707100123.GF71453@hoeg.nl>
References: <CAOfDtXNreaFYKvyR_C15dk9mOqU30_Z4gHxQPkPH5ntY7rRtzA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="lhhpAkuygu+L0poz"
Content-Disposition: inline
In-Reply-To: <CAOfDtXNreaFYKvyR_C15dk9mOqU30_Z4gHxQPkPH5ntY7rRtzA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-hackers@freebsd.org, Ed Maste <emaste@freebsd.org>,
	debian-hurd@lists.debian.org
Subject: Re: [PATCH] avoid assuming MAXPATHLEN in config(8)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jul 2011 10:01:27 -0000


--lhhpAkuygu+L0poz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Robert,

* Robert Millan <rmh@debian.org>, 20110707 11:33:
> config(8) assumes MAXPATHLEN is defined in a few places, but presence
> of this macro isn't garanteed (POSIX says that it is only present when
> a file length limit exists, which may not be the case).

Even though it is good to make our code conform to standards as much as
possible, do keep in mind that your patch also causes a lot of
regressions in that area. The code now uses asprintf(), which is not
part of POSIX. I also think the use of __GLIBC__ is frowned upon.

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--lhhpAkuygu+L0poz
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)

iQIcBAEBAgAGBQJOFYPzAAoJEG5e2P40kaK7YiIP/ie9qFToGbLx+QBkwFBe+gFX
Bi/1R+SbZGANHWD531SJpx/fXoH9moX1QG+Hv4yUJOVxE/vQRQ+KbmDpA7gGuQ3h
W9d3T53sooJxQcXc6bD8gUDOIPzDibDSVqo/o9z5g/x7EV7Si5GgdELlDNClvqDH
XnSipBaDIZvgLn7klsncLO3h2C369ctBcBTBZ+pBx4T7MWJRYc9kSH7Jo7cK8Q+t
O59rldyHCLJhd8//w1fOi2GToaZJT3DlqExtNHU3RfjHVHR0SFhghJR+5CtdA5jp
xMzzMz7l7RflVI38KGTn+kIZqScdso/vZIVMl/OhrT0KoM43lt29+sSrJewX3hlV
a8zLWbh+ktRy4B1FauGCSm5Cfq2P5xiCNRXM7KqyqeKTxZhqGJvEvbVXtAFJ034I
V/GlOhodBsdjELfM/VpSzAyj1lJ27oSJB9LR1p1BDLylBDrgrGdtnZPs8Zz8iyWf
2FbtFUXR25TQ44NlbLktbAxIUEJItRPd3VPUVr3RxUmHxjUtFx3QZb8VBjuOJZzH
+IJ/a/6uGxb9wGUtN/YD5Ex3dsP89JYiV+ar4Bm3bJ+4PKiRb2hU5V7qzJU3+5Cp
mBbbdrlHV5I9OaIsaoqleXd43PePZyH20cqXqWCTOvr+DkJakIRi+TDZTDuELrnV
+JTlQISWbQTS679FFqzf
=vhBk
-----END PGP SIGNATURE-----

--lhhpAkuygu+L0poz--