Date: Thu, 28 Jun 2001 23:21:56 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: Mike Heffner <mheffner@vt.edu> Cc: freebsd-audit@FreeBSD.org, freebsd-print@bostonradio.org Subject: RE: Initial ctlinfo, for checking incoming jobs to lpd Message-ID: <p05101004b7619680d697@[128.113.24.47]> In-Reply-To: <XFMail.20010628184717.mheffner@novacoxmail.com> References: <XFMail.20010628184717.mheffner@novacoxmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
At 6:47 PM -0400 6/28/01, Mike Heffner wrote: >On 28-Jun-2001 Garance A Drosihn wrote: >| The following patch would add a new source file to lpr/common_source, >| called ctlinfo.c. While I have several plans for ctlinfo.c, >| this first cut just replaces calls to link & unlink in >| lpd/recvjob.c with a call to a new routine which does a whole >| bunch of work. > >I'm not too familiar with the code. It's looks pretty good >altogether. Here's just a few little things I noticed: I have a slightly newer version of the patch available at: http://people.freebsd.org/~gad/lpr/ctlinfo.diff or ftp://freefour.acs.rpi.edu/pub/bsdlpr/ctlinfo.diff Changes: Adds $FreeBSD$ lines that I'll want when checking this in Creates a common_source/ctlinfo.h file with ctl-routines declarations and 'struct cjobinfo' in it. For initial debugging purposes, added a TRIGGERTEST_FNAME one can #define (and which is defined). All the fancy new code will only when receiving a job into a spool directory where that filename exists (it is defined to be 'LpdTestRenameTF'. When got to thinking about putting this into RPI's production lpd, I wanted to be able "ease into" using it on a per-printserver, per-queue basis... In that testing mode, also keep track of when we'd EVER actually expand tabs in a cf-file. I strongly suspect I'm going to redo that tab-expansion nonsense before I'm done. It's silly to be looking to expand tabs when many of the fields are filenames. There shouldn't be any tabs in those fields, and if there WERE any tabs then they would literally BE tabs, and should not be expanded into blanks. Note: in ctlinfo.c, the lines from '#include "ctlinfo.h"' to the definition of 'struct cjprivate' will move back down after the other includes. Those lines are just a weird spot for now so I know that the ctlinfo.h file is setup exactly right. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05101004b7619680d697>