From owner-svn-src-all@FreeBSD.ORG Sat Mar 31 13:44:23 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 65EAE1065670; Sat, 31 Mar 2012 13:44:23 +0000 (UTC) Date: Sat, 31 Mar 2012 13:44:23 +0000 From: Alexey Dokuchaev To: Joerg Sonnenberger Message-ID: <20120331134423.GA15782@FreeBSD.org> References: <201203301257.q2UCvE4l042042@svn.freebsd.org> <20120330133045.GD1423@mole.fafoe.narf.at> <4F760E5F.5030300@FreeBSD.org> <20120331111007.GB6658@britannica.bec.de> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20120331111007.GB6658@britannica.bec.de> User-Agent: Mutt/1.4.2.1i Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r233700 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2012 13:44:23 -0000 On Sat, Mar 31, 2012 at 08:10:07PM +0900, Joerg Sonnenberger wrote: > On Fri, Mar 30, 2012 at 09:49:51PM +0200, Dimitry Andric wrote: > > On 2012-03-30 15:30, Stefan Farfeleder wrote: > > >here are a few similar cases. > > > > Hm, what about this one that clang warns about: > > > > sys/dev/asr/asr.c:2420:57: warning: for loop has empty body [-Wempty-body] > > for (ha = &Asr_softc_list; *ha; ha = &((*ha)->ha_next)); > > I would really just move the ha = into the loop body -- same semantic > and no such issue as a dangling ;. I usually write "continue;" instead of just lonely semicolon. Allows to keep "packed" for's and while's, and does not look ambiguous. ./danfe