From owner-svn-ports-all@FreeBSD.ORG  Fri Apr 10 09:04:10 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 7149B483; Fri, 10 Apr 2015 09:04:10 +0000 (UTC)
Date: Fri, 10 Apr 2015 09:04:10 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Bartek Rutkowski <robak@FreeBSD.org>
Subject: Re: svn commit: r383713 - head/www/httpclient
Message-ID: <20150410090410.GA7905@FreeBSD.org>
References: <201504100858.t3A8whLc068918@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201504100858.t3A8whLc068918@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Apr 2015 09:04:10 -0000

On Fri, Apr 10, 2015 at 08:58:43AM +0000, Bartek Rutkowski wrote:
> New Revision: 383713
> URL: https://svnweb.freebsd.org/changeset/ports/383713
> 
> Log:
>   www/httpclient: add CPE information
>   
>   - Maintainer's timeout (ale@FreeBSD.org)

We have a standard form for noting maintainer timeouts:

Approved by:	maintainer (ale, timeout [since ...])

> [...] 
> +USES+=	cpe
> +CPE_PRODUCT=	commons-httpclient
> +CPE_VENDOR=	apache
>  RUN_DEPENDS=	${JAVAJARDIR}/httpcore.jar:${PORTSDIR}/www/httpcore \

Wrong indentation of USES value; bogus use of +=; the whole thing should be
placed after *_DEPENDS block (look for USE_JAVA knob).  Admittedly, the
whole Makefile needs some cleaning.

./danfe