From owner-freebsd-net@freebsd.org Thu Dec 3 01:00:21 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A475FA3EB2E for ; Thu, 3 Dec 2015 01:00:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 86D9A159C for ; Thu, 3 Dec 2015 01:00:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tB310LK9095970 for ; Thu, 3 Dec 2015 01:00:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 189219] [dummynet] [patch] using dummynet on sparc64 and configuring a pipe is an insta-panic Date: Thu, 03 Dec 2015 01:00:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: marius@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 01:00:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=189219 --- Comment #6 from Marius Strobl --- (In reply to Michael Moll from comment #2) That patch is overly complicated for solving the unaligned access triggered by config_link(); it's way simpler to just fix do_config() to properly align dn_link before passing it on in the first place. Moreover, the latter also is the actual culprit here as do_config() casts a random chunk of memory to a struct dn_link pointer. Note, though, that the config_link() triggered unaligned access is only one instance of dummynet(4) misaligning dn_link. The following is a complete fix in that regard: http://people.freebsd.org/~marius/dummynet_unfuck_dn_link.diff However, the same incorrect patterns are used for virtually all of dn_ and additionally in some other stuff like flow ID related functions. So someone still needs to sit down and go through the entirety of ip_dummynet.c, fixing all other unaligned accesses. -- You are receiving this mail because: You are the assignee for the bug.