From owner-svn-src-all@freebsd.org Fri Jul 15 09:14:42 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77CC1B9ACC9; Fri, 15 Jul 2016 09:14:42 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-lf0-x22b.google.com (mail-lf0-x22b.google.com [IPv6:2a00:1450:4010:c07::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EB8541FDC; Fri, 15 Jul 2016 09:14:41 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-lf0-x22b.google.com with SMTP id b199so83341774lfe.0; Fri, 15 Jul 2016 02:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3t4jtgv+l2YkwldAzKCQi8BhyKHATMgnvcmiFIPTgdw=; b=WY4oSixhPJS7aiu/a5z0FqjJ1WDwVRmuzKVaJOnTftbwWh2JXcNqezck46c1nmXOOh xeCWaJdlMWbdwMyjW82ySU+VU0PWXNVZ5jUG+GfCabAJY0lotvRY+A+8DMFiuaNx2gYh 0V2B50QuoWfFkkXDVSpSBY3WvPIyJ73e5QdmQ/UwNUSkE8SZuz63D434CSnW+alDlNqA S99kKj0PqoLI641kteTO+lwaaFO47egy2/T+X2pM5wH4iFb3ZaUShVoo5w8Xu+hpKmNf 5MtFjHT8G97UYAQ6u6s4UYSJruDHKDqQGLJn1AdHmIESXb8++EQ8klxISgmnkYFfMIr8 84dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=3t4jtgv+l2YkwldAzKCQi8BhyKHATMgnvcmiFIPTgdw=; b=VN7b7L7VS9z2XX222c+yc6q2y7Be9ycEGS3EO/eK32oam8/rWp0LxRw8USAKEqIu7V XJzYtLsjIBc2HUxOyi5ycQE4fdZizmLaNwZM2pEuN3Mbat8APt0DAA/k+u/KqeZT1rnu oxTg8ZDFkG6rIt9V5/lRxzIMKt+tO/5KzfjjlYLDarALEVW8YJCOw8gNWJ9TnVIgwL55 pYvWQksvGtJj8c9fO3wnxVz6xODupYtLC5EBy5ai2F2gQVlRxKhsFpOTv2MpmDEEJcJi cyP02Vh4LeJ1PM2HNwN9rESinahImocgTCqyUwGdVfoKfRM7U+1ZbfdiwsWXDhzthGio MpcQ== X-Gm-Message-State: ALyK8tIhbyOnD2FEzvy01ouDvEUWsRa3pU4XRWsGnkEOjY/hZqjZfW6/hBLCy08nYVzvGA== X-Received: by 10.46.32.10 with SMTP id g10mr9660453ljg.42.1468574079356; Fri, 15 Jul 2016 02:14:39 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id 67sm1744594ljj.8.2016.07.15.02.14.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 02:14:38 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 15 Jul 2016 11:14:37 +0200 From: Baptiste Daroussin To: Jung-uk Kim Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302324 - head/lib/libc/locale Message-ID: <20160715091437.lczsxhxffxvp2bq3@ivaldir.etoilebsd.net> References: <201607031500.u63F0Cr8099783@repo.freebsd.org> <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="llh3fvk5woixeh53" Content-Disposition: inline In-Reply-To: <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 09:14:42 -0000 --llh3fvk5woixeh53 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 15, 2016 at 02:19:41AM -0400, Jung-uk Kim wrote: > On 07/03/16 11:00 AM, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sun Jul 3 15:00:12 2016 > > New Revision: 302324 > > URL: https://svnweb.freebsd.org/changeset/base/302324 > >=20 > > Log: > > Fix a bad test resulting in a segfault with ISO-8859-5 locales > > =20 > > Reported by: Lauri Tirkkonen from Illumos > > Approved by: re@ (gjb) > >=20 > > Modified: > > head/lib/libc/locale/collate.c > >=20 > > Modified: head/lib/libc/locale/collate.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libc/locale/collate.c Sun Jul 3 11:45:54 2016 (r302323) > > +++ head/lib/libc/locale/collate.c Sun Jul 3 15:00:12 2016 (r302324) > > @@ -310,7 +310,7 @@ _collate_lookup(struct xlocale_collate * > > if ((sptr =3D *state) !=3D NULL) { > > *pri =3D *sptr; > > sptr++; > > - if ((sptr =3D=3D *state) || (sptr =3D=3D NULL)) > > + if ((sptr =3D=3D *state) || (*sptr =3D=3D 0)) > > *state =3D NULL; > > else > > *state =3D sptr; >=20 > I had a serious regression with ko_KR.UTF-8 locale after this commit. > MATE is unusable because mate-panel is busy looping and eating 100% CPU. > GNOME 3 does not start at all, i.e., nothing but mouse cursor on black > screen. After reverting this commit, everything is back to normal. > Please investigate. IMHO, this must be fixed before 11.0-BETA2 build. >=20 > Thanks, >=20 > Jung-uk Kim >=20 Yes sorry about that, I'm aware of it and working on a fix... Bapt --llh3fvk5woixeh53 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXiKl7AAoJEGOJi9zxtz5aqSUP/A1JRIOh/9sRMU//abPp5vkP RrInAaY3YsfkgUwstXQmy7ImJgT9KPVaWRMu2cJ+NXdQtfpzUVUP8o7LcvRX5F4h /8mlGo4Uv+40OU7Dl2C2ZyRewEj1kyMVdJ/7TEQ+XA52rfUPYUvT8H5YJzQVKhnl GZWgDsEIvs5k7a5ShglKVAto9YmXa09M1mNTDFiwoXG7H63V08pIGa67V/fBc/gb ViEi7xWFduNvYw6c/O0jF/1m8u71nwxxiIiOReScg++qbUXhamZWQnmkSnQqDspN EgyJUeIYK4fEQmu1SHuARV/iM/iR+v6DeW02dI3j/4oHq7a0/5fz6giE1StFZTLb mPl4GhbC6mI/eEhm+gI8TdjszvlKXpFGnj8G60uaHjSSzMhUF0xLnOJAcRNorY3M bzduhF9kASFwgBEstTG20eZl+o5O/RQa+u0/xE9LgQig24lziHch4Dyrkc2U+G/v 9a3dQKjnswJ5cwBfh+lWv9MoeFHQX58NHf+1Yy48YHhXX3RqQ136zA2GHVMcQJer zvasrBMvkxqZOXP4RJDaisokLjBxs4kGAo24Ta9vZf3NL0Z3yU1iOS/pghS33RbD KVffMCXhKh9UoZ/6r0XSFG+e0HS2zEjXo1ZB3F1ou8XB3yKeMxu5Fkm4YEI7S2Gk w+qmHQckWuRbTY9i/wRd =g9c5 -----END PGP SIGNATURE----- --llh3fvk5woixeh53--