From owner-freebsd-current@FreeBSD.ORG Sun Jan 24 11:37:28 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D312F106566B; Sun, 24 Jan 2010 11:37:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id 4468A8FC0A; Sun, 24 Jan 2010 11:37:27 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o0OBbIEe075353 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 24 Jan 2010 13:37:18 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id o0OBbIe8009572; Sun, 24 Jan 2010 13:37:18 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id o0OBbI1E009571; Sun, 24 Jan 2010 13:37:18 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 24 Jan 2010 13:37:18 +0200 From: Kostik Belousov To: Gabor Kovesdan Message-ID: <20100124113718.GC3877@deviant.kiev.zoral.com.ua> References: <20100119212019.GL59590@deviant.kiev.zoral.com.ua> <4B56CACF.50508@FreeBSD.org> <4B5B4F4B.3030201@FreeBSD.org> <20100124091911.GI31243@server.vk2pj.dyndns.org> <4B5C27B9.1080805@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="w7PDEPdKQumQfZlR" Content-Disposition: inline In-Reply-To: <4B5C27B9.1080805@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: attilio@freebsd.org, Hajimu UMEMOTO , Peter Jeremy , current@freebsd.org Subject: Re: NLS/strerror efficiency X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jan 2010 11:37:29 -0000 --w7PDEPdKQumQfZlR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 24, 2010 at 11:58:01AM +0100, Gabor Kovesdan wrote: > El 2010. 01. 24. 10:19, Peter Jeremy escribi?: > >I think this is a good start but still needs some work. One issue is > >that the patch mixes whitespace changes (some not complying with > >style(9)) and functional changes. This makes it harder to see the > >functional changes. > > =20 > I thought fixing up some style(9) nits was ok but I meant them to be=20 > compliant with style(9). Could you please point out, which are not=20 > compliant? Shall I revert the style(9) changes for now? > >How much of an issue is this in reality? There are two cases to > >consider: > >1) A process that dynamically changes its locale. > >2) Locale files being updated whilst the process is running. > > > >The first can be worked around by also caching the current locale > >and checking that it hasn't changed. > > =20 > I'll fix up my patch to do that. > >The second is more problematic - particularly for long-running > >programs. Maybe add a timestamp and re-check every minute or 5. > > =20 > I agree, that it should track changing catalogs but do we really want=20 > that? Catalogs are usually bundled with third-party apps and if you=20 > update something you obviously want to restart that. And in the case of= =20 > strerror(3), catalogs are supposed to be updated with libc and when you= =20 > update libc you probably want to restart everything. I do not think that this ought to be handled. Dynamic locale change, on the other hand, is something I have actually seen. --w7PDEPdKQumQfZlR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAktcMO0ACgkQC3+MBN1Mb4gt8QCeMbX51g0RDUOWduLTJv990M9z AckAoIFckJbaGZ+233pTd/STtcUGCepu =WGGN -----END PGP SIGNATURE----- --w7PDEPdKQumQfZlR--