From owner-svn-src-head@freebsd.org Fri Nov 30 18:15:51 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39D4D114BC19; Fri, 30 Nov 2018 18:15:51 +0000 (UTC) (envelope-from arybchik@FreeBSD.org) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [84.52.114.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AFC346F589; Fri, 30 Nov 2018 18:15:50 +0000 (UTC) (envelope-from arybchik@FreeBSD.org) Received: from [192.168.1.192] (unknown [188.242.181.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2C8587F5F4; Fri, 30 Nov 2018 21:15:42 +0300 (MSK) Subject: Re: svn commit: r341327 - head/sys/dev/sfxge To: John Baldwin References: <201811300711.wAU7B5R6084752@repo.freebsd.org> From: Andrew Rybchenko Organization: OKTET Labs Cc: gnn@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, philip@FreeBSD.org Message-ID: <7545b110-4930-d49f-f99f-7ec17db7e7a7@oktetlabs.ru> Date: Fri, 30 Nov 2018 21:15:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: AFC346F589 X-Spamd-Result: default: False [0.62 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.21)[-0.206,0]; NEURAL_SPAM_SHORT(0.70)[0.698,0]; NEURAL_SPAM_LONG(0.13)[0.126,0]; ASN(0.00)[asn:25408, ipnet:84.52.64.0/18, country:RU] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 18:15:51 -0000 On 30.11.2018 20:30, John Baldwin wrote: > On 11/29/18 11:11 PM, Andrew Rybchenko wrote: >> Author: arybchik >> Date: Fri Nov 30 07:11:05 2018 >> New Revision: 341327 >> URL: https://svnweb.freebsd.org/changeset/base/341327 >> >> Log: >> sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped >> >> Early processing of a packet on transmit may change last seen >> VLAN TCI in the queue context. If such a packet is eventually >> dropped, last seen VLAN TCI must be set to its previous value. >> >> Submitted by: Ivan Malov >> Sponsored by: Solarflare Communications, Inc. >> MFC after: 1 week >> Differential Revision: https://reviews.freebsd.org/D18288 > Just as a general comment. There's no point in creating a review in > phabricator if you aren't going to get any actual review feedback via > the tool. That just adds noise. (I've spotchecked a few of the recent > sfxge commits and they all seem to create a review that then gets committed > a few hours later without any feedback, etc.) All these changesets is the result of development in Solarflare. All these changesets were reviewed internally and in fact many have later fixes which are simply squashed in. We have discussed it with George (gnn@) some time ago and he asked to submit reviews anyway and wait at least a day or two before commit. Yes in this particular case these 2 hundreds of patches is the result of 2 years of development. So, I'd waited some time and started to commit in blocks. This time I've not included np@ and bz@ in reviewers since I've not got reviewed before and it would be too much spam. We have discussed it with Philip (philip@) shortly. As I understand he has no time now to review it. Basically I'm ready to follow any sensible policy. I don't think it makes to wait forever. If there are any volunteers I'll be happy to include more people in reviewers. Andrew.