From owner-freebsd-hackers@FreeBSD.ORG Thu Mar 11 13:17:35 2010 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C06301065674 for ; Thu, 11 Mar 2010 13:17:35 +0000 (UTC) (envelope-from jh@FreeBSD.org) Received: from gw03.mail.saunalahti.fi (gw03.mail.saunalahti.fi [195.197.172.111]) by mx1.freebsd.org (Postfix) with ESMTP id 7EC098FC27 for ; Thu, 11 Mar 2010 13:17:35 +0000 (UTC) Received: from a91-153-117-195.elisa-laajakaista.fi (a91-153-117-195.elisa-laajakaista.fi [91.153.117.195]) by gw03.mail.saunalahti.fi (Postfix) with SMTP id 58B902166EF; Thu, 11 Mar 2010 15:17:29 +0200 (EET) Date: Thu, 11 Mar 2010 15:17:29 +0200 From: Jaakko Heinonen To: Alexander Best Message-ID: <20100311131728.GC3008@a91-153-117-195.elisa-laajakaista.fi> References: <20100311102911.GA2574@a91-153-117-195.elisa-laajakaista.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-hackers@FreeBSD.org, Poul-Henning Kamp , Bruce Evans Subject: Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 13:17:35 -0000 On 2010-03-11, Alexander Best wrote: > in sys/kern/vfs_syscalls.c:kern_rmdirat() there's still local code to check > for "." and "/" after applying your patch. isn't this all being done by > calling namei() now? Looking at it quickly I think that the "." case is handled by lookup() since r199137. However the VV_ROOT test is for all mount points not just for "/". -- Jaakko