From owner-freebsd-x11@FreeBSD.ORG  Wed Jan 23 19:20:01 2013
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
Delivered-To: freebsd-x11@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 3551E69D
 for <freebsd-x11@smarthost.ysv.freebsd.org>;
 Wed, 23 Jan 2013 19:20:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 249B797F
 for <freebsd-x11@smarthost.ysv.freebsd.org>;
 Wed, 23 Jan 2013 19:20:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0NJK1Kd003195
 for <freebsd-x11@freefall.freebsd.org>; Wed, 23 Jan 2013 19:20:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0NJK1SD003194;
 Wed, 23 Jan 2013 19:20:01 GMT (envelope-from gnats)
Date: Wed, 23 Jan 2013 19:20:01 GMT
Message-Id: <201301231920.r0NJK1SD003194@freefall.freebsd.org>
To: freebsd-x11@FreeBSD.org
Cc: 
From: Mark Johnston <markj@freebsd.org>
Subject: Re: ports/175532: x11/xdm: /bin/cp -n
 /usr/local/share/examples/xdm/GiveConsole /usr/local/lib/X11/xdm/GiveConsole
 *** [post-install] Error code 1
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Mark Johnston <markj@freebsd.org>
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2013 19:20:01 -0000

The following reply was made to PR ports/175532; it has been noted by GNATS.

From: Mark Johnston <markj@freebsd.org>
To: bug-followup@FreeBSD.org, ohartman@zedat.fu-berlin.de
Cc: obrien@freebsd.org
Subject: Re: ports/175532: x11/xdm: /bin/cp -n
 /usr/local/share/examples/xdm/GiveConsole /usr/local/lib/X11/xdm/GiveConsole
 *** [post-install] Error code 1
Date: Wed, 23 Jan 2013 12:11:26 -0800

 --LyciRD1jyfeSSjG0
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 I suspect that this is because of r245832, which changed cp -n to return
 an error if the destination file exists. Previously it would just exit
 with a status of 0.
 
 The attached (untested) patch should fix this problem. I'm not sure what
 the general fix should be - there are at least ~20 ports that use cp -n
 in some way or another (found by grepping for '${CP} -[A-Za-z]*n').
 
 -Mark
 
 --LyciRD1jyfeSSjG0
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch
 
 diff --git a/x11/xdm/Makefile b/x11/xdm/Makefile
 index 862050b..028e6e2 100644
 --- a/x11/xdm/Makefile
 +++ b/x11/xdm/Makefile
 @@ -49,7 +49,7 @@ post-configure:
  
  post-install:
  .for f in ${CFFILES}
 -	${CP} -n ${EXAMPLESDIR}/$f ${PREFIX}/lib/X11/xdm/$f
 +	-${CP} -n ${EXAMPLESDIR}/$f ${PREFIX}/lib/X11/xdm/$f
  .endfor
  	${MKDIR} /var/lib/xdm/authdir
  	${LN} -sf /var/lib/xdm/authdir ${PREFIX}/lib/X11/xdm/authdir
 
 --LyciRD1jyfeSSjG0--