From owner-svn-ports-all@freebsd.org Wed Mar 17 19:27:59 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2366F57607B; Wed, 17 Mar 2021 19:27:59 +0000 (UTC) (envelope-from steve@mouf.net) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F10YW0GkWz3CdL; Wed, 17 Mar 2021 19:27:58 +0000 (UTC) (envelope-from steve@mouf.net) Received: from lrrr.mouf.net (cpe-76-182-16-135.nc.res.rr.com [76.182.16.135]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id 12HJRjai084252 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 17 Mar 2021 19:27:54 GMT (envelope-from steve@mouf.net) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mouf.net; s=mail; t=1616009277; bh=UkpRshK+BMXRMzYetc18rWSayxAhCnVOzVDrFgMOE8I=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=VVjwN5HJmYRurbdfYL0zJZYi26FuXw3FKDh6A0xp8GOZFYXL7OgMwjj0/7D7/KdGU LoER0ru7oIbbjnjPnPfqnpqc631A9e01T5cxkav4Ghqu2TN0ZS8EpK0jTUwcTy+LFY Li9nq7p8VTU96dGFmK0UZr0FqaxtdInAUnrbTHlU= Subject: Re: svn commit: r568508 - head/devel/node-gyp To: Mathieu Arnold , Juraj Lutter Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202103152102.12FL2tRP068067@repo.freebsd.org> <20210316211715.pa4w3lrffzxr3ftx@aching.in.mat.cc> <2239997E-E3B6-403F-B36D-4326CDF16EFE@FreeBSD.org> <20210316221912.smaeylfqtx7yfm6i@aching.in.mat.cc> From: Steve Wills Message-ID: <80fc0f66-44b1-f7d3-fc36-b78d63bc753b@mouf.net> Date: Wed, 17 Mar 2021 15:27:40 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210316221912.smaeylfqtx7yfm6i@aching.in.mat.cc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Wed, 17 Mar 2021 19:27:54 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=KHOP_HELO_FCRDNS, NICE_REPLY_A autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-Rspamd-Queue-Id: 4F10YW0GkWz3CdL X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 19:27:59 -0000 Hi, On 3/16/21 6:19 PM, Mathieu Arnold wrote: > > The rationale being that given X ports that depend on a node module, you > will probably need more than X versions of that module because they > will all depend on incompatible versions of said module. I think this applies to Go modules as well. It might be good to document this, if it isn't already. Maybe other things too, like Rust, etc? Even with python/ruby etc. there's a lot of need for multiple versions, but I guess it's not as much. > A port that requires node modules must provide its own. It can > absolutely be by having an extra step for the maintainer to generate a > tarball with all the required modules that can simply be extracted as > needed. I have not checked, but there are probably ports already doing > this. > Which leads to the point that since ports/Mk/Uses/go.mk provides a way to do this, maybe ports/Mk/Uses/node.mk should as well? Just a thought. Cheers, Steve