Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 May 2024 08:43:47 -0700
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        Ravi Pokala <rpokala@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: 0d3789584915 - main - ctl: use socket buffer mutexes in struct socket directly
Message-ID:  <ZlC1s6Bbz_hBYeIz@cell.glebi.us>
In-Reply-To: <1B513920-69CF-434E-B5A1-45960CB99246@panasas.com>
References:  <202405231912.44NJCLja032047@gitrepo.freebsd.org> <1B513920-69CF-434E-B5A1-45960CB99246@panasas.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 23, 2024 at 12:21:23PM -0700, Ravi Pokala wrote:
R> Hi Gleb,
R> 
R> Isn't this the exact opposite of the summary? This change *doesn't* use the mutexes directly, it uses the wrappers to *avoid* using the mutexes directly.

SOCKBUF_LOCK(&so->so_rcv) locks via pointer in the buffer to the
socket.

SOCK_RECVBUF_LOCK(so) locks directly in the socket.

-- 
Gleb Smirnoff



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZlC1s6Bbz_hBYeIz>