Date: Mon, 4 Nov 2002 06:31:14 -0500 (EST) From: Trevor Johnson <trevor@jpj.net> To: Kris Kennaway <kris@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>, Eric Melville <eric@FreeBSD.org>, Akinori Musha <knu@FreeBSD.org>, <ports@FreeBSD.org> Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <20021104062332.M50593-100000@blues.jpj.net> In-Reply-To: <20021103223004.GB25257@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote:
> On Sun, Nov 03, 2002 at 09:27:28AM -0500, Trevor Johnson wrote:
[Kris wrote]
> > > * If the ${COMMENT} file does not exist, use the value of the
> > > ${PORTCOMMENT} variable instead. This will allow us to incrementally
> > > phase out pkg-comment [1]
[...]
> > PORTCOMMENT=""
> >
> > leaves only 66 for the comment itself, unless a continuation card is
> > used. NetBSD and OpenBSD have chosen the
> > shorter name COMMENT instead. That leaves 70 columns for the comment.
> > Our portlint recommends 70 (or fewer columns), so existing ports which
> > pass portlint are already consistent with the shorter name, but not
> > necessarily with the longer one.
[...]
> The problem with using COMMENT is that a number of ports already
> override it, so this patch breaks them.
A revised patch--untested--is at
<URL:http://people.freebsd.org/~trevor/ports/comment.diff>.
--
Trevor Johnson
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021104062332.M50593-100000>