From owner-freebsd-hackers@freebsd.org Fri Nov 3 02:46:09 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8145E695DE for ; Fri, 3 Nov 2017 02:46:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 78E8E7385E for ; Fri, 3 Nov 2017 02:46:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x231.google.com with SMTP id 101so3340619ioj.3 for ; Thu, 02 Nov 2017 19:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=itWTTX9c3DyQmal3w4PwTj84lYg35nAVNJVnPqYrFdw=; b=oAOF9SJL1PAZuUivSpzKa29PMXgDSiW99bJo7hvlBvMjqIWwrDFXOb9/dpQ1dgwUPx /EjWtRsILwFx5ahr9ojOcaoF11FxD9y8yrq6vlBYhlSQAb1zN2wnljj4/bsA4G5Rq177 IC9YqvnuK9ELUlgsZKO56LOAN6JfcCKe0NwUJZRF+p0Z6ivyNSr/zohES6O6ixB/r4bI D7J98aktOVdW7ppYlobeE24b1/FOTa9dhKuP5hVkrR+OSemZZ5mH5s/dwP36ZaZRSNWs OnnIBowy/eklMnVSj/HsOAfCysfEiEgtBCWiMHTjea3T1WaIhJ8vmeF+xIi9K+EbvsZ8 z/nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=itWTTX9c3DyQmal3w4PwTj84lYg35nAVNJVnPqYrFdw=; b=DFZvea7JgdVrK1resbMwOAE9067TTp37hxgrhol0RGNQjUrv40QIXV2Hrh/aBFVUlM V8qfRbxOGenwVEI0j26CVQK9y3T5gYMS0PSSLtAGmBxS2LmhWSdWZKED/cjNSBYwFTVt ff89N8cftesdROBZ6LAkNgkqR6k5almmSoqVxXnL0i964HsUUYWBZlq/PYNjGEJiOLGY 2RyKvBB45tpltu2OOQ92v6b/ysy4+MdO6DM8glCHm90mJwP9Oxy8nB0tps9rXXYeiNeY OMCREBfYllgIpKzdDf4G4RzGUCLgKK+PIzX+DR37nzVd0ZSbpcND696RdSYu9wK5OQkF I0Sg== X-Gm-Message-State: AJaThX53daKFX0NYf9du8Ls2eranZoJ7+Gq6JKrDnGflnP4XKY5GVzh7 7UZBsKzOVSg4V9KY2SVizv6OF+KtAuOHjuBKFf1eAg== X-Google-Smtp-Source: ABhQp+QccZO6vu3Tl5MHjM7ak6/PvwReGJ1moQ0X0DPvM9L1L764bptPvejXlOwOrX8IfKOGGqraphqiZ6XS6eKPUzM= X-Received: by 10.107.52.134 with SMTP id b128mr7261724ioa.291.1509677168605; Thu, 02 Nov 2017 19:46:08 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.57.22 with HTTP; Thu, 2 Nov 2017 19:46:07 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:a004:68c9:b567:b3a8] In-Reply-To: <998FF503-D4B0-4AD5-AD55-98680E4D66CA@FreeBSD.org> References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org> <20171103014907.GA88522@troutmask.apl.washington.edu> <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> <20171103022327.GA88659@troutmask.apl.washington.edu> <998FF503-D4B0-4AD5-AD55-98680E4D66CA@FreeBSD.org> From: Warner Losh Date: Thu, 2 Nov 2017 20:46:07 -0600 X-Google-Sender-Auth: 5wZ40yowwbjgdom3Qo4ypLN2NWU Message-ID: Subject: Re: Head build unsafe for /etc today To: Bryan Drewery Cc: Steve Kargl , freebsd-hackers , FreeBSD Toolchain , FreeBSD Current Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 02:46:09 -0000 On Thu, Nov 2, 2017 at 8:41 PM, Bryan Drewery wrote: > > > > On Nov 2, 2017, at 19:23, Steve Kargl > wrote: > > > >> On Thu, Nov 02, 2017 at 07:08:50PM -0700, Bryan Drewery wrote: > >> > >> > >>>> On Nov 2, 2017, at 18:49, Steve Kargl edu> wrote: > >>>> > >>>> On Thu, Nov 02, 2017 at 06:25:24PM -0700, Bryan Drewery wrote: > >>>> > >>>> On Nov 2, 2017, at 15:44, Mark Millard wrote: > >>>> > >>>>>> Author: bdrewery > >>>>>> Date: Thu Nov 2 22:23:00 2017 > >>>>>> New Revision: 325347 > >>>>>> URL: > >>>>>> https://svnweb.freebsd.org/changeset/base/325347 > >>>>>> > >>>>>> > >>>>>> Log: > >>>>>> Something is very wrong > >>>> > >>>> > >>>> Unfortunately I only test with META_MODE these days which implies > -DNO_CLEAN. > >>> > >>> You're making changes to the build infrastructure and you're > >>> not properly testing it before committing? This is beyond > >>> pointyhat material. > >> > >> I ran 2 universes, dozens of buildworlds and buildkernels, dozens of > installworld and installkernel, several xdev and native-xtools, several > full DIRDEPS_BUILD builds and bootstraps, ran subdir builds, ran subdir > cleans, tested several targets together, ran various special case tests f= or > submakes, played around with a ton of MAKEOBJDIRPREFIX cases, handled and > tested symlinked objdirs special, ran it through my work repro a few time= s, > did special testing in rescue/, and had a volunteer test release. In the > process I found a bmake bug, GPL_DTC build bug and several others I don= =E2=80=99t > recall from the bus. > >> > >> What I missed was the =E2=80=9Cclean=E2=80=9D buildworld because I for= got it even > exists. I=E2=80=99ve wanted to remove it for a year. I also forgot to tes= t buildenv. > >> > > > > If you did all the above under META_MODE, then no you did not > > buildworld and buildkernel and all the other stuff you claim. > > Are you accusing me of lying? > > > > If your first step isn't 'cd /usr/obj ; rm -rf *' or equivalent > > in whatever jail you use, then you're not properly testing > > your changes to the build > > I did that probably 100 times. And that isn=E2=80=99t even =E2=80=9Cthe p= roper test=E2=80=9D. Both > clean and incremental are needed which I did. zfs snapshots help a lot > there. I just never ran =E2=80=9C_cleanobj=E2=80=9D which does a full tre= e walk of clean. > But I ran make clean in some subdirs many times. > > > infrastructure. As you have demonstrated, > > Makefile, Makefile.inc1, and the *.mk files are sufficiently > > complicated that proper testing > > > should be done, and proper > > testing means one doesn't takes shortcuts. > > I took 0 shortcuts. As I said I *forgot* that case, among hundreds of > cases. > You=E2=80=99re welcome to do this work if you want. I guarantee you would= not have > tested even half of what I tested. > > Hey can you fix universe to only build clang once please? I=E2=80=99ve be= en > working up to that but I think you=E2=80=99re best to do it. Given the hundreds of commits to the build system and its complexity, I'm in awe this doesn't happen more often. Heck, I've done an order of magnitude fewer commits to the build system and broken it more often than you have, and that's when it was a much simpler beast than it is today. Steve's just being overly grumpy imho. Accidents happen despite one's best efforts. This is -current after all... Warner