From owner-freebsd-acpi@FreeBSD.ORG Wed Sep 5 20:36:59 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0B431065675 for ; Wed, 5 Sep 2012 20:36:59 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 131418FC23 for ; Wed, 5 Sep 2012 20:36:58 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA21292; Wed, 05 Sep 2012 23:36:56 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1T9MLI-0003KQ-AK; Wed, 05 Sep 2012 23:36:56 +0300 Message-ID: <5047B7E7.5080802@FreeBSD.org> Date: Wed, 05 Sep 2012 23:36:55 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:15.0) Gecko/20120901 Thunderbird/15.0 MIME-Version: 1.0 To: Kevin Oberman References: <4FF95F79.30309@FreeBSD.org> <1341935370.4493.4.camel@powernoodle> <4FFFD891.2060109@FreeBSD.org> <5046F105.80706@FreeBSD.org> <504779D8.4030909@FreeBSD.org> <50477E9F.7030604@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@FreeBSD.org Subject: Re: improve cx_lowest logic X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2012 20:36:59 -0000 on 05/09/2012 20:41 Kevin Oberman said the following: > On Wed, Sep 5, 2012 at 9:32 AM, Andriy Gapon wrote: >> on 05/09/2012 19:23 Kevin Oberman said the following: >>> On Wed, Sep 5, 2012 at 9:12 AM, Andriy Gapon wrote: >>>> on 05/09/2012 18:17 Kevin Oberman said the following: >>>>> Thanks so much! This should finally make Cx states work on my >>>>> ThinkPad! I really appreciate it. Guess it's time to do my weekly >>>>> upgrade of this system. >>>> >>>> I haven't sneaked in that other commit :-( >>> >>> Oops! :-( >>> >>> Oh, well. At least it should make it to /base/stable/9 soon. Right??? >>> (I only run release/ or releng/ or for an occasional test.) >>> >> >> It's already in stable/9 :) > > Ahh! I now see C3/109, but I see some strange behavior. When on AC > power, only C1/1 and C2/104 are available, but cx_lowest is C3, even > though C3 is not available. If I switch to battery, C1/1, C2/80 and > C3/109 are available (???), but cx_lowest is set to C2. I find the Cx > value sets a bit odd, but the setting of cx_lowest appears to be a > bug, at least to me. I can manually set cx_lowest to C3 and I actually > use C3. > > My suspicion is that there is either a race or a logic issue where > x_lowest is reset to the lowest value before the available Cx values > are set, so cx_lowest is always set the the lowest Cx state from the > previous power configuration. (This is a guess, but it fits what I am > seeing very well.) > Hmm, this looks like the older behavior. What revision are you at? Also, any local ACPI-related patches? -- Andriy Gapon