Date: Sun, 13 Sep 2015 16:41:13 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396826 - head/x11/metisse Message-ID: <20150913144112.GA22783@ivaldir.etoilebsd.net> In-Reply-To: <20150913143014.GA59597@FreeBSD.org> References: <201509131424.t8DEOxgd093250@repo.freebsd.org> <20150913143014.GA59597@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 13, 2015 at 02:30:14PM +0000, Alexey Dokuchaev wrote: > On Sun, Sep 13, 2015 at 02:24:59PM +0000, Baptiste Daroussin wrote: > > New Revision: 396826 > > URL: https://svnweb.freebsd.org/changeset/ports/396826 > >=20 > > Log: > > Clean options by using options helpers > > Remove gtk1 option > > Nuke usage of HAVE_GOME. > > Please notice that the port is stil wrong as it still relies on the > > configure script to autodetect things instead of control[l]ing it > > depending on options. At least it is now a bit cleaner[.] >=20 > (Fixed some typos for you) Thanks >=20 > Thanks, but I don't see the reason for this part: >=20 > > -post-patch: .SILENT > > +post-patch: > > # Catch up with new <fribidi-types.h> header name > > - ${REINPLACE_CMD} -e 's,fribidi_types\.h,fribidi-types.h,' \ > > + @${REINPLACE_CMD} -e 's,fribidi_types\.h,fribidi-types.h,' \ > > ${WRKSRC}/fvwm-insitu/libs/FBidi.c > > # Fix desktop entries path > > - ${REINPLACE_CMD} -E 's,^(configdir =3D).*,\1 ${DESKTOPDIR},' \ > > + @${REINPLACE_CMD} -E 's,^(configdir =3D).*,\1 ${DESKTOPDIR},' \ > > ${WRKSRC}/fvwm-insitu/opale/session/Makefile.in > > -.if defined(_NOGLADEDIR) > > - ${REINPLACE_CMD} -e 's, install-gladeDATA,,' \ > > - ${WRKSRC}/fvwm-insitu/modules/FvwmConfig/Makefile.in > > -.endif > > - ${REINPLACE_CMD} -e 's,return;,return 0;,' \ > > + @${REINPLACE_CMD} -e 's,return;,return 0;,' \ >=20 > What was wrong with .SILENT? (I ask because it was originally my port.) Absolutely nothing, just got habbit of '@' I hesitated twice before that ch= ange and probably picked up the wrong decision or let say have added gratuicious change. Bapt --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlX1iwgACgkQ8kTtMUmk6EwUMwCePLPWXr9eZIrihl5j7OQuFzlr lQ8AoL4gYkSv9WuYKG6lRIuMrxSkc2+K =WkuM -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150913144112.GA22783>