Date: Wed, 22 Jan 2014 01:33:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Alex Dupre <ale@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r340618 - head/security/cryptlib Message-ID: <20140122013352.GA12715@FreeBSD.org> In-Reply-To: <201401211633.s0LGXRLP049969@svn.freebsd.org> References: <201401211633.s0LGXRLP049969@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 21, 2014 at 04:33:27PM +0000, Alex Dupre wrote: > New Revision: 340618 > URL: http://svnweb.freebsd.org/changeset/ports/340618 > QAT: https://qat.redports.org/buildarchive/r340618/ > > +OPTIONS_DEFINE= DOCS Couple of observations. :) OPTIONS are normally placed below all other knobs (traditionally). > + ${LN} -sf ${PREFIX}/lib/libcl.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libcl.so.3 > + ${LN} -sf ${PREFIX}/lib/libcl.so.3 ${STAGEDIR}${PREFIX}/lib/libcl.so Per our own wiki.freebsd.org/ports/StageDir: "When creating a symlink, prepend ${STAGEDIR} to the target path only (and generally try to avoid using absolute paths in source). [...] Note that source of ${PREFIX}/lib/libfoo.so.42, while seemingly okay, could be in fact incorrect, since absolute path can potentially point to a wrong location, e.g. when remote filesystem (with installed package) is mounted via NFS under non-root mount point. Relative paths are less fragile (and often much shorter)." ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140122013352.GA12715>