From owner-freebsd-gnome@FreeBSD.ORG Wed Jun 3 22:30:33 2009 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 425A2106566B for ; Wed, 3 Jun 2009 22:30:33 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id D0F398FC1A for ; Wed, 3 Jun 2009 22:30:32 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.3/8.14.3) with ESMTP id n53MUZQr021220; Wed, 3 Jun 2009 18:30:35 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Ed Schouten In-Reply-To: <20090603221507.GC48776@hoeg.nl> References: <20090603221507.GC48776@hoeg.nl> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-KKjwU2XBhKx2xoRAq1av" Organization: MarcusCom, Inc. Date: Wed, 03 Jun 2009 18:30:03 -0400 Message-Id: <1244068203.1290.2.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on creme-brulee.marcuscom.com Cc: gnome@freebsd.org Subject: Re: [Patch] Build libiconv with USE_CSTD=gnu89 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2009 22:30:33 -0000 --=-KKjwU2XBhKx2xoRAq1av Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2009-06-04 at 00:15 +0200, Ed Schouten wrote: > Hi all, >=20 > Pav just added support to the Ports tree to easily specify the C > standard in the port makefiles. Even though the compiler in our base > system uses -std=3Dgnu89 by default, this behaviour could change in the > future. Other compilers (like Clang) already use ISO C99 by default. In > most cases this won't matter, but there are some subtleties. >=20 > One of the ports that really requires the C standard to be set to gnu89, > is libiconv. The problem is that this port uses GNU-style inlining, > which is only enabled when building C89 code. >=20 > I propose the following patch: >=20 > --- converters/libiconv/Makefile > +++ converters/libiconv/Makefile > @@ -17,6 +17,7 @@ > =20 > USE_AUTOTOOLS=3D libtool:15 > GNU_CONFIGURE=3D yes > +USE_CSTD=3D gnu89 > USE_GNOME=3D gnometarget > LIBTOOLFILES=3D configure libcharset/configure > CONFIGURE_ARGS=3D --enable-static \ >=20 > It shouldn't change the behaviour of the port when using GCC, but allows > us Clang folks to build libiconv out of the box. Erwin ran an > experimental ports build with Clang on pointyhat and according to > numbers, libiconv's failure caused it to skip compilation of 9600 other > ports... >=20 > Any comments? I'm fine with this. Feel free to commit. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-KKjwU2XBhKx2xoRAq1av Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkom+WoACgkQb2iPiv4Uz4cMPgCdG0jiIX9yE2lRpC/gcO6yjZGH i7kAniSb+K+vFmruBofy4sfA2E6w601V =jCul -----END PGP SIGNATURE----- --=-KKjwU2XBhKx2xoRAq1av--