From owner-svn-src-head@freebsd.org Thu May 24 22:36:22 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1650F6B231; Thu, 24 May 2018 22:36:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B9CBE87A7E; Thu, 24 May 2018 22:36:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 8357D14826; Thu, 24 May 2018 22:36:21 +0000 (UTC) (envelope-from jhb@freebsd.org) From: John Baldwin To: Matt Macy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcstat... Date: Thu, 24 May 2018 15:36:07 -0700 Message-ID: <2291583.vLXA4fx7TA@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201805240430.w4O4U6Js001134@repo.freebsd.org> References: <201805240430.w4O4U6Js001134@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 22:36:22 -0000 On Thursday, May 24, 2018 04:30:06 AM Matt Macy wrote: > Author: mmacy > Date: Thu May 24 04:30:06 2018 > New Revision: 334128 > URL: https://svnweb.freebsd.org/changeset/base/334128 > > Log: > libpmcstat: compile in events based on json description Please provide more detail for commits like this in the future. Some questions I have some of which probably should have been answered in the log: - Why does this matter? For example, does this provide counters for a CPUs we don't currently support counters on? - Does this supplant the existing tables of counters in hwpmc or is this a different set of counters (or how do these counter tables interact with our existing tables in general)? - What is the origin of these json files? What is the license? These seem to come straight from the Linux kernel which should be acknowledged via Obtained from: at the very least. It does seem that the jevents source is explicitly BSD licensed (2 clause). This is noted in the git logs in the Linux tree. However, I couldn't find a clear statement on the json files themselves and what their license is. Are you aware of a license for those or do they fall under the GPLv2 "default" license in /COPYING of the Linux source tree? -- John Baldwin