From owner-dev-commits-src-all@freebsd.org Mon Apr 26 16:47:48 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C4CB05E77F7 for ; Mon, 26 Apr 2021 16:47:48 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FTW6D545gz3r7H for ; Mon, 26 Apr 2021 16:47:48 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-yb1-xb32.google.com with SMTP id g38so65653699ybi.12 for ; Mon, 26 Apr 2021 09:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qIso/IGesM5YWOI4ruHu69jBQlRV2Dpjr71o4oovUQM=; b=rrobfrRhuCN/4zNxbwRZ4Synai+4CaUpfl4VMybNEQnFaNGN066o+QGlw2az9Bq64T O/d0Wk5I/YxWPm3eDIx/ZjfXP4Pw/F5FWhb+cqX8ueNWt22tLQan2rRO6G2iTV2cEG3X f6tb5BwQLur/uxCE2C7JA3cf2FzSwrZHhcip8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qIso/IGesM5YWOI4ruHu69jBQlRV2Dpjr71o4oovUQM=; b=KljJwZ9qxcw18ANbaQQ7vtmAbXF4zw+qhq0/2lBwNd0valcmNAyqkOSDbehGSOB1fR cmtLQRC9XEdbd6jgQ6gW67BCnM1H87yCcckzaXB2xGHzPOLY5P4R9aqAQC0gz5X9IVx6 Xmtc0sYKqk3+1Ec/y26QBreQSU1pvbaZpZeK529Val/JlaGmzpBhtLgPjjSchYIhUmsA C1sD2BsVJ4THEoNx5nI2DDAL1oCEBUGKaN0kXYCq+gWThFwvRjL8gzh57xqydHug+GEo VVb12WPc1TVZYESCX59fNOE7IzOWfpeSpEMUdj5SX2ocGc7HdGol0XJt4xHud6k+FMsD T80A== X-Gm-Message-State: AOAM531ez4bFSjSkWrkbGNY7lzmgpIm4m+fH6r/r49hWT4WtABOgBx7p S8LFirkAVeF45JXemzaLQHk+KJ9Eg4WdBrnrx96o3A== X-Google-Smtp-Source: ABdhPJynmr2MVtxFmvIEEJPM13zU51qdlI1p5Vk98xu132IGOyGEHPLzg3cw/L2tsptq3VmZC+LYBoOTSyNKperzAGc= X-Received: by 2002:a25:330a:: with SMTP id z10mr25996374ybz.123.1619455667716; Mon, 26 Apr 2021 09:47:47 -0700 (PDT) MIME-Version: 1.0 References: <202104261525.13QFPrbg086311@gitrepo.freebsd.org> In-Reply-To: <202104261525.13QFPrbg086311@gitrepo.freebsd.org> From: Kevin Bowling Date: Mon, 26 Apr 2021 09:47:36 -0700 Message-ID: Subject: Re: git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave() To: Neel Chauhan Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4FTW6D545gz3r7H X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2021 16:47:48 -0000 Hi Neel, I'm not sure all the context or conversation here but the convention is to not use bare return values, i.e in style(9) "Values in return statements should be enclosed in parentheses." and that's what was asked to be changed on this mailing list. Can you use and link to Phabricator for your src commits? As much as possible it is preferable to get it right in one go, for MFCs, bisection, etc and this kind of churn should be preventable with quick reviews. Feel free to tag me as a reviewer. Regards, Kevin On Mon, Apr 26, 2021 at 8:25 AM Neel Chauhan wrote: > > The branch main has been updated by nc (ports committer): > > URL: https://cgit.FreeBSD.org/src/commit/?id=e657f3de6dc29147b5373d2cc2cc47e580931e30 > > commit e657f3de6dc29147b5373d2cc2cc47e580931e30 > Author: Neel Chauhan > AuthorDate: 2021-04-26 15:25:33 +0000 > Commit: Neel Chauhan > CommitDate: 2021-04-26 15:25:33 +0000 > > linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave() > --- > sys/compat/linuxkpi/common/include/linux/spinlock.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sys/compat/linuxkpi/common/include/linux/spinlock.h b/sys/compat/linuxkpi/common/include/linux/spinlock.h > index 1ad8f8ff1aad..83f45b1a2a40 100644 > --- a/sys/compat/linuxkpi/common/include/linux/spinlock.h > +++ b/sys/compat/linuxkpi/common/include/linux/spinlock.h > @@ -166,9 +166,8 @@ atomic_dec_and_lock_irqsave(atomic_t *cnt, spinlock_t *lock, > unsigned long flags) > { > spin_lock_irqsave(lock, flags); > - if (atomic_dec_and_test(cnt)) { > + if (atomic_dec_and_test(cnt)) > return 1; > - } > spin_unlock_irqrestore(lock, flags); > return 0; > } > _______________________________________________ > dev-commits-src-main@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org"