From owner-svn-src-all@freebsd.org Fri Oct 18 16:00:00 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8742C1555DF; Fri, 18 Oct 2019 16:00:00 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vrMg23C8z3GZX; Fri, 18 Oct 2019 15:59:58 +0000 (UTC) (envelope-from ohartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1571414383; bh=E0Hzq67jyMpDXiLIE5+62UlwouI/OT45vg9wu+7KeSQ=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=e7Zw5tcuN7hIwHHDTAw+312NNvfHuNdRB2Bd/SC3xx8h40ujGUvC+2E9/UTLbqY4P YLJCUcH36T0yZL5XQZfJDQU5ROf8fmzvCRH0FtfhDupsL4FFP51ZzE27tae+IZgqVP pA7qmegXqW1X8KizhH3xy5bKaa+iGn4hzvD/NEcI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from hermann.fritz.box ([91.65.85.161]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N0Fxf-1i9UHG1qP1-00xO8P; Fri, 18 Oct 2019 17:54:17 +0200 Date: Fri, 18 Oct 2019 17:54:06 +0200 From: "Hartmann, O." To: Cy Schubert Cc: "Hartmann, O." , svn-src-head@freebsd.org, Gary Jennejohn , src-committers@freebsd.org, svn-src-all@freebsd.org, Conrad Meyer Subject: Re: svn commit: r353700 - in head: share/man/man4 sys/amd64/conf sys/conf sys/gdb sys/i386/conf sys/kern sys/net sys/sys Message-ID: <20191018175406.0ff89bbc@hermann.fritz.box> In-Reply-To: <201910181424.x9IEOC9q013885@slippy.cwsent.com> References: <201910172133.x9HLX1kl071044@repo.freebsd.org> <20191018122104.389ffb7a@hermann.fritz.box> <20191018140045.31d269b0@ernst.home> <20191018160935.7dda61c4@hermann.fritz.box> <201910181424.x9IEOC9q013885@slippy.cwsent.com> Organization: walstatt.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/w8CGTs2D0os+h1ujbS5RYJO"; protocol="application/pgp-signature" X-Provags-ID: V03:K1:vZUR95Jj0HrPjDDmhrG6wVYJwJrHxjGRiGnzpItcJzGTO8EwbW/ NX77oG9kEVf3RghzVNNaucOvFGI4tsdmQuR0sM3i4llLN2GdRz2YMUPdVbUKCyDHmYvvq4U leAyk/oHjxB7iAoJYI8+rtsJb+iTRU/OWpgS58jLqERWgmJhUHb5VBkLkIgF+OLr/4+U2VE dpNetB1eXL/QHsg+uaElw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:k3g4RdYWJNE=:v3s6w4DHEWMKaihoomYWT3 GITKMoMo9tdEYqXNaKxUEq75r2tTHf1rJxsrSTk/P18AjfcXo+Vsuo3txLEQHMBEJ2Jz++UQi xrsSDTuX28CouUiv84z8eWR3vgkwbPeLOLi7yDT9rkGUWDEmggH7jICuhkQfMIXjSR6m81urN jZjb8DyCuKO3eeBRzi8XUqAGJZTy6yx35xky1fMazGTDnCFHySKTqow/MreZxNjYOAQQNCsaa eyLqkQrdPrdUeUZp8icSnyuQIoeOR0G89DcEil/JLO5xFR2Ckem3yOiuO9pJP6MSbZFIOg7cn 1s3hWq1dgtJu+Mb5rt1UoE3W4F/eU6NbVoM1A84MmkKfoQJSAAGwDkQ3znt8sS7c2ZZPyZwb4 t5L3W1u4p9U+cg4DyeD4dPTtXaG8RWfIv463HpJZPHVxGQkQH2P1gg3KNr/rJWzJMnTEv/vwn jax9+sY6cngFhMXlgu9GDF+TrGDDj1g9kS3ZZ0ymPK+MTPPCZ+psI8G8FZw9zps2g0tamVyJY Fk7XLxCKUq0ILRpmpjCOl6yFc/sFHkgHBzEYiLXrck4sk8oWvd6KSsQt6UxBDr0sEhLtHvA5q HhdqOzJ8C3namfm7RYKwGQcSE9XTNFV5HmnHb99aexJhyTwkkHFZwxunkjaxHhseHZkdEzVWb bRLloa2S8oHlPGlXukApfRmmuGVNbA2+Lg8TlH/7LrAVTOHx3ayLaJJoAQzOTkWwY6d4e3FAD KgwhYnCyjf9ueShi7fbS4D8tAZVHUfTpxXIl/qfJFv3K99+OD+MIzQR/CTWstjAyuuV31LYUF 779BheGDbOIK0LU3p0jmnm72yuOYo5u+KgBIr1kxBf0HHQXMkUygIH3YzSNqm2Cjjw5GW5cSz RsK7tEtB3gbSL/beozlcKJqdBdU1wDFiHtWYjJvGVcB4KIaE1YXGuLXe3HAp1F31J07YbltTS cDK5EViTn2sq8La2XnkZ7RKXezsFva5NrDTsarKwL8jVsiRUqG898TV8xam5Nd+IPogfiL9Ua OklFZtfhhZ3hrJTySgoC3wne3ypdKDn6JHWIA2gHXZ6b0VGoCKMMqQpq6jWn5H/7UkbIPG8au CYoC3Hp0Ucidrjxrjx2KNaJTjlTB3zmWT378GGS6NfSOutFGuzRzxw1ijfhIlQLrxjU+WB109 Jud9E9itVtsWAz7jI0fNb452fY9wkrEgNo5MZfgrwGbvZYSLwokD4SFOC3CvyLX2LK6dbT8lp VDDIf/b245aMAmugzUrOYdkW5enT+WAj0VAOuENDNEpdo3WYW7e/vNy1uI4Y= X-Rspamd-Queue-Id: 46vrMg23C8z3GZX X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=e7Zw5tcu; dmarc=none; spf=none (mx1.freebsd.org: domain of ohartmann@walstatt.org has no SPF policy when checking 212.227.17.20) smtp.mailfrom=ohartmann@walstatt.org X-Spamd-Result: default: False [-5.67 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-1.17)[ip: (-6.50), ipnet: 212.227.0.0/16(-1.35), asn: 8560(2.00), country: DE(-0.01)]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[walstatt.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; HAS_ORG_HEADER(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmx.net:+]; RCPT_COUNT_SEVEN(0.00)[7]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[20.17.227.212.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[161.85.65.91.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2019 16:00:00 -0000 --Sig_/w8CGTs2D0os+h1ujbS5RYJO Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 18 Oct 2019 07:24:12 -0700 Cy Schubert wrote: > In message <20191018160935.7dda61c4@hermann.fritz.box>, "Hartmann, > O." writes: > > --Sig_/QDD9BZgeMM6.TJkOIciNb32 > > Content-Type: text/plain; charset=3DUS-ASCII > > Content-Transfer-Encoding: quoted-printable > > > > On Fri, 18 Oct 2019 14:00:45 +0200 > > Gary Jennejohn wrote: > > =20 > > > On Fri, 18 Oct 2019 12:21:04 +0200 > > > "Hartmann, O." wrote: > > >=3D20 =20 > > > > On Thu, 17 Oct 2019 21:33:01 +0000 (UTC) > > > > Conrad Meyer wrote: > > > > =3D20 =20 > > > > > Author: cem > > > > > Date: Thu Oct 17 21:33:01 2019 > > > > > New Revision: 353700 > > > > > URL: https://svnweb.freebsd.org/changeset/base/353700 > > > > >=3D20 > > > > > Log: > > > > > Implement NetGDB(4) > > > > > =3D20 > > > > > NetGDB(4) is a component of a system using a panic-time > > > > > network stack to remotely debug crashed FreeBSD kernels over > > > > > the network, instead of traditional serial interfaces. > > > > > =3D20 > > > > > There are three pieces in the complete NetGDB system. > > > > > =3D20 > > > > > First, a dedicated proxy server must be running to accept > > > > > connections from both NetGDB and gdb(1), and pass > > > > > bidirectional traffic between the two protocols. > > > > > =3D20 > > > > > Second, the NetGDB client is activated much like ordinary > > > > > 'gdb' and similarly to 'netdump' in ddb(4) after a panic. > > > > > Like other debugnet(4) clients (netdump(4)), the network > > > > > interface on the route to the proxy server must be online and > > > > > support debugnet(4). =3D20 > > > > > Finally, the remote (k)gdb(1) uses 'target remote > > > > > :' (like any other TCP remote) to connect to the > > > > > proxy server.=3D20 > > > > > The NetGDB v1 protocol speaks the literal GDB remote serial > > > > > protocol, and uses a 1:1 relationship between GDB packets and > > > > > sequences of debugnet packets (fragmented by MTU). There is > > > > > no encryption utilized to keep debugging sessions private, so > > > > > this is only appropriate for local segments or trusted > > > > > networks. =3D20 > > > > > Submitted by: John Reimer > > > > > (earlier version) Discussed some with: emaste, markj > > > > > Relnotes: sure > > > > > Differential Revision: > > > > > https://reviews.freebsd.org/D21568 > > > > >=3D20 > > > > > Added: > > > > > head/share/man/man4/netgdb.4 (contents, props changed) > > > > > head/sys/gdb/netgdb.c (contents, props changed) > > > > > head/sys/gdb/netgdb.h (contents, props changed) > > > > > Modified: > > > > > head/share/man/man4/Makefile > > > > > head/share/man/man4/ddb.4 > > > > > head/sys/amd64/conf/GENERIC > > > > > head/sys/conf/NOTES > > > > > head/sys/conf/files > > > > > head/sys/conf/options > > > > > head/sys/gdb/gdb.h > > > > > head/sys/gdb/gdb_int.h > > > > > head/sys/gdb/gdb_main.c > > > > > head/sys/gdb/gdb_packet.c > > > > > head/sys/i386/conf/GENERIC > > > > > head/sys/kern/subr_kdb.c > > > > > head/sys/net/debugnet.c > > > > > head/sys/net/debugnet.h > > > > > head/sys/net/debugnet_inet.c > > > > > head/sys/net/debugnet_int.h > > > > > head/sys/sys/kdb.h > > > > > head/sys/sys/param.h > > > > >=3D20 > > > > > Modified: head/share/man/man4/Makefile > > > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > > > > =20 > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D =20 > > > > > --- head/share/man/man4/Makefile Thu Oct 17 21:25:50 > > > > > 2019 (r353699) +++ head/share/man/man4/Makefile > > > > > Thu Oct 17 21:33:01 2019 (r353700) @@ -307,6 +307,7 @@ > > > > > MAN=3D3D aac.4 \ net80211.4 \ > > > > > netdump.4 \ > > > > > netfpga10g_nf10bmac.4 \ > > > > > + netgdb.4 \ > > > > > netgraph.4 \ > > > > > netintro.4 \ > > > > > netmap.4 \ > > > > > =3D20 =20 > > > > [...] > > > >=3D20 > > > >=3D20 > > > > Having "nooptions NETGDB # netgdb(4) client > > > > support" defined in my kernel config file, buildkernel fails > > > > with the error shown below. > > > >=3D20 > > > > [...] > > > > --- debugnet.o --- > > > > /usr/src/sys/net/debugnet.c:662:4: error: implicit declaration > > > > of function 'db_printf' is invalid in C99 > > > > [-Werror,-Wimplicit-function-declaration] db_printf("%s: Could > > > > not get route for that server.\n", ^ > > > > /usr/src/sys/net/debugnet.c:662:4: note: did you mean > > > > 'if_printf'? /usr/src/sys/net/if_var.h:679:5: note: 'if_printf' > > > > declared here int if_printf(struct ifnet *, const char *, > > > > ...) __printflike(2, 3); ^ 1 error generated. =3D20 =20 > > >=3D20 > > > And I also had to add "nooptions NETDUMP" to get the kernel to > > > compile and link. > > >=3D20 =20 > > > > I already had "nooptions NETDUMP" defined. =20 >=20 >=20 > This will fix it. >=20 > Index: sys/net/debugnet.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/net/debugnet.c (revision 353717) > +++ sys/net/debugnet.c (working copy) > @@ -659,8 +659,10 @@ > CURVNET_RESTORE(); > =20 > if (dest_rt =3D=3D NULL) { > +#ifdef DDB > db_printf("%s: Could not get route for that > server.\n", __func__); > +#endif > error =3D ENOENT; > goto cleanup; > } >=20 >=20 >=20 Doesn't work, either. The kernel config in question doesn't have any debugging features enabled, so nooptions DDB is alos part of the configuration. buildkernel still fails. --Sig_/w8CGTs2D0os+h1ujbS5RYJO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQSy8IBxAPDkqVBaTJ44N1ZZPba5RwUCXangHgAKCRA4N1ZZPba5 R3XjAP95797t8GjhHOEpWzpRgVnqCUqwlILMCfnfNGg7utiT/wD+K68c0jUlNech 9/peDfPKI5RNnoLf2+LYRIsyErjF2g0= =eD7J -----END PGP SIGNATURE----- --Sig_/w8CGTs2D0os+h1ujbS5RYJO--