Date: Thu, 3 Dec 2020 12:54:08 -0500 From: Steve Wills <swills@FreeBSD.org> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r556857 - head/databases/memcached Message-ID: <5644977d-5147-cadb-1987-059caa5bbe5a@FreeBSD.org> In-Reply-To: <X8keWPl2qKjf4u/M@KGPE-D16> References: <202012022203.0B2M3lcs000847@repo.freebsd.org> <c839004a-ac44-0ed9-0d32-c1c18852ac81@FreeBSD.org> <X8keWPl2qKjf4u/M@KGPE-D16>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Right, I was saying they are OK but you need to have an "Approved by:" line just to be clear. Steve On 12/3/20 12:20 PM, Piotr Kubaj wrote: > Thanks for feedback, I just assumed that trivial patches for Tier 2 architectures that have no way of affecting Tier 1 are ok. > > On 20-12-02 22:28:30, Steve Wills wrote: >> Hi, >> >> No objection here, happy to see this actually, but this needed a PR and >> approval or at the least a "Approved by: tier 2 blanket" line. >> >> Steve >> >> On 12/2/20 5:03 PM, Piotr Kubaj wrote: >>> Author: pkubaj >>> Date: Wed Dec 2 22:03:47 2020 >>> New Revision: 556857 >>> URL: https://svnweb.freebsd.org/changeset/ports/556857 >>> >>> Log: >>> databases/memcached: enable DTRACE on powerpc64 head >>> >>> -no-integrated-as is ommitted, since as can't build the compiler-generated code. memcached nevertheless builds. >>> >>> Modified: >>> head/databases/memcached/Makefile >>> >>> Modified: head/databases/memcached/Makefile >>> ============================================================================== >>> --- head/databases/memcached/Makefile Wed Dec 2 21:48:25 2020 (r556856) >>> +++ head/databases/memcached/Makefile Wed Dec 2 22:03:47 2020 (r556857) >>> @@ -3,6 +3,7 @@ >>> >>> PORTNAME= memcached >>> PORTVERSION= 1.6.8 >>> +PORTREVISION= 1 >>> CATEGORIES= databases >>> MASTER_SITES= http://www.memcached.org/files/ \ >>> GENTOO >>> @@ -33,6 +34,11 @@ OPTIONS_DEFINE= DOCS SASL >>> OPTIONS_DEFAULT= SASL >>> OPTIONS_DEFINE_amd64= DTRACE >>> OPTIONS_DEFAULT_amd64= DTRACE >>> +OPTIONS_DEFINE_powerpc64= DTRACE >>> +OPTIONS_DEFAULT_powerpc64= DTRACE >>> +OPTIONS_EXCLUDE_powerpc64= ${OPTIONS_EXCLUDE_${ARCH}_${OSREL:R}} >>> +OPTIONS_EXCLUDE_powerpc64_11= DTRACE >>> +OPTIONS_EXCLUDE_powerpc64_12= DTRACE >>> >>> .if !exists(/usr/sbin/dtrace) >>> OPTIONS_EXCLUDE+= DTRACE >>> @@ -61,12 +67,12 @@ CONFIGURE_ARGS+= --enable-tls >>> USES+= ssl >>> .endif >>> >>> -.if ${ARCH} == amd64 >>> +.if ${ARCH} == amd64 || ${ARCH} == powerpc64 >>> CONFIGURE_ARGS+= --enable-64bit >>> .endif >>> >>> # avoid triggering a bug in libdtrace, see illumos issue 6653 >>> -.if ${PORT_OPTIONS:MDTRACE} >>> +.if ${PORT_OPTIONS:MDTRACE} && ${ARCH} == amd64 >>> CFLAGS+= -no-integrated-as >>> .endif >>> >>>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5644977d-5147-cadb-1987-059caa5bbe5a>