From owner-svn-ports-all@freebsd.org Thu Dec 3 17:54:29 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1C1294ABCFC; Thu, 3 Dec 2020 17:54:29 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cn3Pc5yQKz4YYQ; Thu, 3 Dec 2020 17:54:28 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-76-182-16-135.nc.res.rr.com [76.182.16.135]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id 0B3HsCrc025021 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 3 Dec 2020 17:54:18 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r556857 - head/databases/memcached To: Piotr Kubaj Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202012022203.0B2M3lcs000847@repo.freebsd.org> From: Steve Wills Message-ID: <5644977d-5147-cadb-1987-059caa5bbe5a@FreeBSD.org> Date: Thu, 3 Dec 2020 12:54:08 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Thu, 03 Dec 2020 17:54:18 +0000 (UTC) X-Spam-Status: No, score=0.3 required=4.5 tests=KHOP_HELO_FCRDNS, NICE_REPLY_A autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-Rspamd-Queue-Id: 4Cn3Pc5yQKz4YYQ X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; ASN(0.00)[asn:36236, ipnet:2607:fc50::/36, country:US] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2020 17:54:29 -0000 Hi, Right, I was saying they are OK but you need to have an "Approved by:" line just to be clear. Steve On 12/3/20 12:20 PM, Piotr Kubaj wrote: > Thanks for feedback, I just assumed that trivial patches for Tier 2 architectures that have no way of affecting Tier 1 are ok. > > On 20-12-02 22:28:30, Steve Wills wrote: >> Hi, >> >> No objection here, happy to see this actually, but this needed a PR and >> approval or at the least a "Approved by: tier 2 blanket" line. >> >> Steve >> >> On 12/2/20 5:03 PM, Piotr Kubaj wrote: >>> Author: pkubaj >>> Date: Wed Dec 2 22:03:47 2020 >>> New Revision: 556857 >>> URL: https://svnweb.freebsd.org/changeset/ports/556857 >>> >>> Log: >>> databases/memcached: enable DTRACE on powerpc64 head >>> >>> -no-integrated-as is ommitted, since as can't build the compiler-generated code. memcached nevertheless builds. >>> >>> Modified: >>> head/databases/memcached/Makefile >>> >>> Modified: head/databases/memcached/Makefile >>> ============================================================================== >>> --- head/databases/memcached/Makefile Wed Dec 2 21:48:25 2020 (r556856) >>> +++ head/databases/memcached/Makefile Wed Dec 2 22:03:47 2020 (r556857) >>> @@ -3,6 +3,7 @@ >>> >>> PORTNAME= memcached >>> PORTVERSION= 1.6.8 >>> +PORTREVISION= 1 >>> CATEGORIES= databases >>> MASTER_SITES= http://www.memcached.org/files/ \ >>> GENTOO >>> @@ -33,6 +34,11 @@ OPTIONS_DEFINE= DOCS SASL >>> OPTIONS_DEFAULT= SASL >>> OPTIONS_DEFINE_amd64= DTRACE >>> OPTIONS_DEFAULT_amd64= DTRACE >>> +OPTIONS_DEFINE_powerpc64= DTRACE >>> +OPTIONS_DEFAULT_powerpc64= DTRACE >>> +OPTIONS_EXCLUDE_powerpc64= ${OPTIONS_EXCLUDE_${ARCH}_${OSREL:R}} >>> +OPTIONS_EXCLUDE_powerpc64_11= DTRACE >>> +OPTIONS_EXCLUDE_powerpc64_12= DTRACE >>> >>> .if !exists(/usr/sbin/dtrace) >>> OPTIONS_EXCLUDE+= DTRACE >>> @@ -61,12 +67,12 @@ CONFIGURE_ARGS+= --enable-tls >>> USES+= ssl >>> .endif >>> >>> -.if ${ARCH} == amd64 >>> +.if ${ARCH} == amd64 || ${ARCH} == powerpc64 >>> CONFIGURE_ARGS+= --enable-64bit >>> .endif >>> >>> # avoid triggering a bug in libdtrace, see illumos issue 6653 >>> -.if ${PORT_OPTIONS:MDTRACE} >>> +.if ${PORT_OPTIONS:MDTRACE} && ${ARCH} == amd64 >>> CFLAGS+= -no-integrated-as >>> .endif >>> >>>