From owner-dev-commits-src-all@freebsd.org Fri Feb 26 16:04:05 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B4354565492; Fri, 26 Feb 2021 16:04:05 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnDx101N7z4TDn; Fri, 26 Feb 2021 16:04:04 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 07C28580681; Fri, 26 Feb 2021 11:04:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 26 Feb 2021 11:04:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.dev; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=p jWy5zhXhg868uXzaGIkMYNeziBKcxOt0ewqMXal5Zs=; b=tihQ+qVkSKiR5X6uQ 6wL8YccBaLesCWZsWa0DkfkaPOKVN5DurGSxHCAJRxXaEajwcDyjZsUj1q8hSrCn Cp5n1kK3BMv4c45beRGnHmi5JB9QLTwtHWmamn25+LqKhL9z7jwvGtrDY078RNx3 z8tPi3ggU7pWv8M+M1yAZNVrO4IKI8mIeOk0p2bNos2OUDzCpMPKIKKPLEqHV3uT JFvNlvRBG8w6to2eLeLmRg8SKQFZELiY4urGxi6kjqSwQJBKMv6mBDi9J+MT+w7l w7UHcGTZ0D8PUjh4gJ0Z3N3b4AqjiHgO1VAKtcdQo3goNAXeNg2jIVdcAHb5cg5J 84JLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=pjWy5zhXhg868uXzaGIkMYNeziBKcxOt0ewqMXal5 Zs=; b=MeJI7qYgWn6UaWDVUTheO195ddDCX0BWCT+uwiAKgnQ2xHTOaNfqvOtxb IeRutuSljTG8vaN1XXMr77dASZzC6h6fCYGIot5XfhRNB+j4sxB0QQ9OSxmiMYtp j1JVWoqGG1Vhrb3Wn6/Y6LgcAxaPeIyBPbNKHitIYVpbr89xXGqs7AcwDtYmW19w Ai5xtxhOungfjb2bggsEoN84kVqpDnBOZSQC/yE96z+AwurCkg/1a3H6Pm1qmG4F oouwhSU1+Vz2Pw4tHwxfgtOuGI5Ek07uhzXqvWi2vmacWepahsMVmXFzwAWp1pgI ZUp+gUe+xoSc2VIOECqoiO1vMBO8Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrledugdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpegjuhhrihcu rfgrnhhkohhvuceohihurhhiphhvseihuhhrihhpvhdruggvvheqnecuggftrfgrthhtvg hrnhepveetudeuteegteeileduieetgfelvdehtdekteejveejjefhudeffeeuleetledv necuffhomhgrihhnpehfrhgvvggsshgurdhorhhgpdhprhhoghdrmhhknecukfhppeelud drvdegtddruddvgedrudefjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpeihuhhrihhpvheshihurhhiphhvrdguvghv X-ME-Proxy: Received: from [192.168.1.6] (unknown [91.240.124.137]) by mail.messagingengine.com (Postfix) with ESMTPA id EC6E1240064; Fri, 26 Feb 2021 11:04:01 -0500 (EST) Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database To: Cy Schubert , Baptiste Daroussin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202102251327.11PDR4eC083842@gitrepo.freebsd.org> <202102261420.11QEKJoX006569@slippy.cwsent.com> From: Yuri Pankov Message-ID: <68cc80bb-04fe-ef23-6f5a-2bc77db54feb@yuripv.dev> Date: Fri, 26 Feb 2021 19:04:00 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <202102261420.11QEKJoX006569@slippy.cwsent.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DnDx101N7z4TDn X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yuripv.dev header.s=fm1 header.b=tihQ+qVk; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=MeJI7qYg; dmarc=none; spf=pass (mx1.freebsd.org: domain of yuripv@yuripv.dev designates 66.111.4.221 as permitted sender) smtp.mailfrom=yuripv@yuripv.dev X-Spamd-Result: default: False [-3.60 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.221]; RWL_MAILSPIKE_GOOD(0.00)[66.111.4.221:from]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[yuripv.dev:+,messagingengine.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[66.111.4.221:from]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.221:from]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[yuripv.dev:s=fm1,messagingengine.com:s=fm2]; FREEFALL_USER(0.00)[yuripv]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[yuripv.dev]; SPAMHAUS_ZRD(0.00)[66.111.4.221:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 16:04:05 -0000 Cy Schubert wrote: > In message <202102251327.11PDR4eC083842@gitrepo.freebsd.org>, Baptiste > Daroussi > n writes: >> The branch main has been updated by bapt: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=2a50a9de8340f08bd876e9e5993332ae >> 14376f80 >> >> commit 2a50a9de8340f08bd876e9e5993332ae14376f80 >> Author: Baptiste Daroussin >> AuthorDate: 2021-02-23 16:17:32 +0000 >> Commit: Baptiste Daroussin >> CommitDate: 2021-02-25 13:25:32 +0000 >> >> terminfo: add terminfo database >> >> Tested by: manu, jbeich >> --- >> share/Makefile | 1 + >> share/terminfo/Makefile | 34 ++++++++++++++++++++++++++++++++++ >> 2 files changed, 35 insertions(+) >> >> diff --git a/share/Makefile b/share/Makefile >> index c4e12b05f7db..d6854b230ae5 100644 >> --- a/share/Makefile >> +++ b/share/Makefile >> @@ -26,6 +26,7 @@ SUBDIR= ${_colldef} \ >> ${_syscons} \ >> tabset \ >> termcap \ >> + terminfo \ >> ${_timedef} \ >> ${_vt} \ >> ${_zoneinfo} >> diff --git a/share/terminfo/Makefile b/share/terminfo/Makefile >> new file mode 100644 >> index 000000000000..7bb11f3fdf24 >> --- /dev/null >> +++ b/share/terminfo/Makefile >> @@ -0,0 +1,34 @@ >> +PACKAGE= runtime >> + >> +.PATH: ${SRCTOP}/contrib/ncurses/misc >> +TINFOBUILDDIR= ${.OBJDIR}/builddir >> +CLEANDIRS+= builddir >> + >> +.include >> + >> +.if !defined(_SKIP_BUILD) >> +all: terminfo >> +.endif >> +META_TARGETS+= terminfo install-terminfo >> + >> +terminfo: terminfo.src >> + mkdir -p ${TINFOBUILDDIR} >> + ${TIC_CMD} -x -o ${TINFOBUILDDIR} ${.ALLSRC} >> + >> +.if make(*install*) >> +TINFOS!= cd ${TINFOBUILDDIR} && find * -type f | LC_ALL=C sort >> +TINFOSDIRS= ${TINFOS:C/(.).*/\1/g:O:u} >> +.endif >> + >> +beforeinstall: install-terminfo >> +install-terminfo: >> + mkdir -p ${DESTDIR}/usr/share/terminfo >> + cd ${DESTDIR}/usr/share/terminfo; mkdir -p ${TINFOSDIRS} >> +.for f in ${TINFOS} >> + ${INSTALL} ${TAG_ARGS} \ >> + -o ${BINOWN} -g ${BINGRP} -m ${NOBINMODE} \ >> + ${TINFOBUILDDIR}/${f} ${DESTDIR}/usr/share/terminfo/${f} >> +.endfor >> + >> +.include >> + >> > > I think this had some unintended consequences, a POLA violation that should > be documented. Our termcap didn't support alternate screen buffers while > terminfo does. Termcap did through t_te and t_ti but we didn't use them. > Terminfo as delivered from the ncurses factory does supply rmcup and smcup; > our fullscreen apps such as nvi and top see them and use the alternate > screen buffer. I don't think this is correct, it's 'ti' and 'te' for termcap and we use those a lot in our database, e.g. xterm-clear or even default screen and tmux entries, so it's always there for me being tmux user. > The use of the alternate screen buffer is one of the things I hate about > Linux. After running vi or top I expect the output to remain on the screen > so I can use some bit of information in my next command. We now have this > behaviour too. It's matter of taste, yes, and I like it. > The alternate screen buffer was added to xterm an ice age ago. Most modern > terminal emulators support it. As much as I feel the need to yank out rmcup > an smcup from our terminfo database, we are using a feature, as distasteful > as it may feel. This change probably needs a relnotes=yes and an UPDATING > entry advising users that they can either change $TERM to xterm1, vt100, or > some other terminal definition that doesn't support rmcup and smcup, or > learn to like it. > > OTOH, maybe this is something we as a community don't really want and we > remove the rmcup and smcup definitions from our terminfo database. > Personally, I believe this is progress -- progress I'm not particularly > enamoured with but progress nonetheless. But I think we need to discuss, > come to some sort of decision and document it. Removing those entirely will break POLA which started this discussion; to not break POLA we should rather "fix" the xterm entry to exclude smcup/rmcup to be the same as termcap equivalent.