From owner-freebsd-current@FreeBSD.ORG Sun Feb 8 22:47:46 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6311C16A4CE for ; Sun, 8 Feb 2004 22:47:46 -0800 (PST) Received: from smtp.mho.com (smtp.mho.net [64.58.4.5]) by mx1.FreeBSD.org (Postfix) with SMTP id 26DBC43D1D for ; Sun, 8 Feb 2004 22:47:46 -0800 (PST) (envelope-from scottl@freebsd.org) Received: (qmail 71824 invoked by uid 1002); 9 Feb 2004 06:47:43 -0000 Received: from unknown (HELO freebsd.org) (64.58.1.252) by smtp.mho.net with SMTP; 9 Feb 2004 06:47:43 -0000 Message-ID: <40272C79.6040708@freebsd.org> Date: Sun, 08 Feb 2004 23:45:13 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.5) Gecko/20031103 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Peter Losher References: <40247AE9.6070805@gddsn.org.cn> <20040207062617.GC49373@teleri.net> <20040209063331.A11582@farside.isc.org> In-Reply-To: <20040209063331.A11582@farside.isc.org> Content-Type: multipart/mixed; boundary="------------090405000902050808040707" cc: current@freebsd.org Subject: Re: Processes blocked on getblk or ufs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2004 06:47:46 -0000 This is a multi-part message in MIME format. --------------090405000902050808040707 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Peter Losher wrote: > On Sat, 7 Feb 2004, Chip Norkus wrote: > > >>>woo, Scott's commit seem to fix this problem for me! >>> >> >>I think I can throw a 'me too' in here. A build (make -j8 world) which >>would reliably lock up one of my 2650s no longer does so. This is >>extremely encouraging. :) Thanks so much for the hard work on this! > > > Any chance this can be backported to RELENG_5_2? Because as it is now 5.2 > is unusable on Dell systems using the aac driver. > > -Peter Can you try the attached patch? Scott --------------090405000902050808040707 Content-Type: text/plain; name="aac_unmap.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="aac_unmap.diff" Index: aac.c =================================================================== RCS file: /usr/ncvs/src/sys/dev/aac/aac.c,v retrieving revision 1.81 diff -u -r1.81 aac.c --- aac.c 9 Nov 2003 09:17:20 -0000 1.81 +++ aac.c 9 Feb 2004 06:41:57 -0000 @@ -1290,8 +1290,10 @@ cm->cm_flags |= AAC_CMD_MAPPED; /* put the FIB on the outbound queue */ - if (aac_enqueue_fib(sc, cm->cm_queue, cm) == EBUSY) + if (aac_enqueue_fib(sc, cm->cm_queue, cm) == EBUSY) { + aac_unmap_command(cm); aac_requeue_ready(cm); + } return; } --------------090405000902050808040707--