From owner-svn-src-all@FreeBSD.ORG Sat Mar 6 15:25:44 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB4AC1065673; Sat, 6 Mar 2010 15:25:44 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 7A7EC8FC13; Sat, 6 Mar 2010 15:25:44 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2FE9C.dip.t-dialin.net [217.226.254.156]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 6D5B8844587; Sat, 6 Mar 2010 16:25:39 +0100 (CET) Received: from unknown (unknown [192.168.2.110]) by outgoing.leidinger.net (Postfix) with ESMTP id A03715046; Sat, 6 Mar 2010 16:25:36 +0100 (CET) Date: Sat, 6 Mar 2010 16:25:35 +0100 From: Alexander Leidinger To: Doug Barton Message-ID: <20100306162535.000078b8@unknown> In-Reply-To: References: <201003051434.o25EYXBR024375@svn.freebsd.org> X-Mailer: Claws Mail 3.7.2cvs15 (GTK+ 2.16.0; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 6D5B8844587.4CD9A X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.763, required 6, autolearn=disabled, ALL_TRUSTED -1.44, J_CHICKENPOX_21 0.60, TW_SV 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1268493940.03434@w5eLlu5LLRtIAINyJPWbFQ X-EBL-Spam-Status: No Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204759 - in head: etc/defaults etc/rc.d share/man/man5 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2010 15:25:44 -0000 On Fri, 5 Mar 2010 21:18:00 +0000 (UTC) Doug Barton wrote: > On Fri, 5 Mar 2010, Alexander Leidinger wrote: > > > Author: netchild > > Date: Fri Mar 5 14:34:33 2010 > > New Revision: 204759 > > URL: http://svn.freebsd.org/changeset/base/204759 > > I've got no comments on the jail-related stuff given that my > knowledge of jails is almost non-existent. However I wish you had run > your diff past freebsd-rc@ since if you had I (or someone else) could > have let you know that the attached patch is a much cleaner way of > implementing the bit about conditionalizing "parallel" execution > (which, to the extent I understand the problem I agree with your > solution of only doing it at when starting, FWIW). > > In general we try to avoid having any code in rc.d scripts run > unconditionally. In this case it's harmless (although every cpu cycle > counts) but in other cases it can cause problems, which is why as a > general rule it's safer to avoid it altogether. I assume your version covers onestart, forcestart faststart and start (I can imagine situations where a prestart should be different from a preforcestart, but I doubt we differentiate in the code). The reason why I chose the case was, that forcestart and onestart are more interactive options. I could imagine that someone tells in the future that it may be better to ignore the jail_parallel_start in those cases. Can the one/force part be detected in the prestart? The trick with command_args is neat, but it is a pitfall in case someone wants to use it in the future. Wouldn't it be better to add the ampersand to it instead of letting the ampersand replace the value? Whatever your answers are, feel free to change what you want to change (as long as the feature remains... my main concern is to solve the bugs, not how to solve them). Bye, Alexander.