From owner-svn-src-head@freebsd.org Fri Nov 30 18:35:58 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2AA89114C43B; Fri, 30 Nov 2018 18:35:58 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f175.google.com (mail-it1-f175.google.com [209.85.166.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8AA4F70080; Fri, 30 Nov 2018 18:35:57 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f175.google.com with SMTP id h193so10734182ita.5; Fri, 30 Nov 2018 10:35:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=SOby22t/g8gsXow9WxIngFiLMUfUri8FqhYoSBGxCAM=; b=WWXBc6W04b4sN9ghDkfKzPBTyQTF33vlG/CnRtyCJ/Kz4k0KYgAiGPIleBAvyX2iSt JBBHgty3n+tbn21uF6kzEjAL4zEuKl5H6MkH/CfkPBAzn+i7W7j+UCqi6B0JpDH1bgYl p2HnjJZ2MNRFvXJZqbyquafCvKwTlMP7lb633dJVYLK0xVdaa3IH3igsaNZkDX5jH73W 2yl0cCPHvKRQzF9vY9L4MKm2r8AEeZnqMry6xpw4W0kmGjJHYkbO/SG5oAjfk73gLW5/ jcJYg5+kCcA0zTNa0jxVLUXvma4jB8D42eaQvyPYQB/7qPg0lJYZJdWUHzyGxu4M8oc7 KZwA== X-Gm-Message-State: AA+aEWa33odo4kWse/hAJls49yu9+PY1WR7MvNROh699sdaMZrVzAUQc cQRzSpS/j6CmR/Y603xbm+ngae/u X-Google-Smtp-Source: AFSGD/W68jGJZYq78TXHH+H0BdbgsfXTzUYcaBT27B/mqAyPPG/ersW7x1nNptu1X4ipx2ff6hJlRA== X-Received: by 2002:a24:2c50:: with SMTP id i77mr5490213iti.131.1543602956352; Fri, 30 Nov 2018 10:35:56 -0800 (PST) Received: from mail-it1-f170.google.com (mail-it1-f170.google.com. [209.85.166.170]) by smtp.gmail.com with ESMTPSA id n16sm2247047iom.58.2018.11.30.10.35.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Nov 2018 10:35:56 -0800 (PST) Received: by mail-it1-f170.google.com with SMTP id o19so10528899itg.5; Fri, 30 Nov 2018 10:35:56 -0800 (PST) X-Received: by 2002:a02:a791:: with SMTP id e17mr802316jaj.104.1543602955699; Fri, 30 Nov 2018 10:35:55 -0800 (PST) MIME-Version: 1.0 References: <201811300711.wAU7B5R6084752@repo.freebsd.org> <7545b110-4930-d49f-f99f-7ec17db7e7a7@oktetlabs.ru> In-Reply-To: <7545b110-4930-d49f-f99f-7ec17db7e7a7@oktetlabs.ru> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Fri, 30 Nov 2018 10:35:44 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r341327 - head/sys/dev/sfxge To: arybchik@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8AA4F70080 X-Spamd-Result: default: False [-5.61 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(-2.62)[ip: (-8.28), ipnet: 209.85.128.0/17(-3.42), asn: 15169(-1.34), country: US(-0.09)]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; RCVD_IN_DNSWL_NONE(0.00)[175.166.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 18:35:58 -0000 On Fri, Nov 30, 2018 at 10:16 AM Andrew Rybchenko wr= ote: > Basically I'm ready to follow any sensible policy. Hi Andrew, I think general policy is to not include a "Differential Revision:" line in a commit message unless there was actual review there. (That's separate from the issue of creating a bunch of reviews that no one will ever look at =E2=80=94 which is a different kind of spam.) > Yes in this particular case these 2 hundreds of patches is the result of = 2 years of development. Why are they being committed now, hundreds at a time, instead of as they were developed over the last two years? Thanks, Conrad