Date: Sat, 3 Mar 2012 15:29:40 -0500 (EST) From: Michael Scheidell <scheidell@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/165670: [PATCH] sysutils/smartmontools: Respect NOPORTDOCS var Message-ID: <20120303202940.2BFBD1D40D@scanner.secnap.net> Resent-Message-ID: <201203032030.q23KUEXC097499@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 165670 >Category: ports >Synopsis: [PATCH] sysutils/smartmontools: Respect NOPORTDOCS var >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Mar 03 20:30:13 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Michael Scheidell >Release: FreeBSD 7.4-RELEASE-p3 i386 >Organization: SECNAP Network Security >Environment: >Description: NOPORTDOCS env var is not being honored. >How-To-Repeat: make -DNOPORTDOCS install you will see that there are leftovers: <http://people.freebsd.org/~scheidell/smartmontools-5.42_3.log>; === Checking filesystem state list of extra files and directories in / (not present before this port was installed but present after it was deinstalled) 7451334 8 drwxr-xr-x 3 root wheel 512 Feb 28 02:08 usr/local/share/doc/smartmontools 7451335 8 -r--r--r-- 1 root wheel 1568 Feb 28 02:08 usr/local/share/doc/smartmontools/AUTHORS 7451336 360 -r--r--r-- 1 root wheel 183421 Feb 28 02:08 usr/local/share/doc/smartmontools/CHANGELOG 7451337 40 -r--r--r-- 1 root wheel 17992 Feb 28 02:08 usr/local/share/doc/smartmontools/COPYING 7451338 64 -r--r--r-- 1 root wheel 31710 Feb 28 02:08 usr/local/share/doc/smartmontools/INSTALL 7451339 40 -r--r--r-- 1 root wheel 19110 Feb 28 02:08 usr/local/share/doc/smartmontools/NEWS 7451340 8 -r--r--r-- 1 root wheel 3823 Feb 28 02:08 usr/local/share/doc/smartmontools/README 7451341 8 -r--r--r-- 1 root wheel 169 Feb 28 02:08 usr/local/share/doc/smartmontools/TODO 7451342 16 -r--r--r-- 1 root wheel 5265 Feb 28 02:08 usr/local/share/doc/smartmontools/WARNINGS 7451343 16 -r--r--r-- 1 root wheel 6706 Feb 28 02:08 usr/local/share/doc/smartmontools/smartd.conf 7451346 8 drwxr-xr-x 2 root wheel 512 Feb 28 02:08 usr/local/share/doc/smartmontools/examplescripts 7451347 8 -r--r--r-- 1 root wheel 2009 Feb 28 02:08 usr/local/share/doc/smartmontools/examplescripts/README 7451348 8 -r-xr-xr-x 1 root wheel 1547 Feb 28 02:08 usr/local/share/doc/smartmontools/examplescripts/Example1 7451349 8 -r-xr-xr-x 1 root wheel 722 Feb 28 02:08 usr/local/share/doc/smartmontools/examplescripts/Example2 7451350 8 -r-xr-xr-x 1 root wheel 693 Feb 28 02:08 usr/local/share/doc/smartmontools/examplescripts/Example3 7451351 8 -r-xr-xr-x 1 root wheel 126 Feb 28 02:08 usr/local/share/doc/smartmontools/examplescripts/Example4 >Fix: as per <http://www.freebsd.org/doc/en/books/porters-handbook/install.html>; don't populate DOCSDIR if NOPORTDOCS is defined. --- sysutils_smartmontools.patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/sysutils/smartmontools/Makefile,v retrieving revision 1.57 diff -u -r1.57 Makefile --- Makefile 15 Feb 2012 08:46:57 -0000 1.57 +++ Makefile 28 Feb 2012 03:58:37 -0000 @@ -22,7 +22,7 @@ GNU_CONFIGURE= yes CONFIGURE_ARGS= --disable-dependency-tracking \ --enable-drivedb --enable-sample \ - --with-docdir=${DOCSDIR} --with-initscriptdir=${PREFIX}/etc/rc.d + --with-initscriptdir=${PREFIX}/etc/rc.d SUB_FILES= pkg-message smart USE_RC_SUBR= smartd @@ -32,6 +32,12 @@ PORTDOCS= * +.if defined(NOPORTDOCS) +CONFIGURE_ARGS+= --without-docdir --without-exampledir +.else +CONFIGURE_ARGS+= --with-docdir=${DOCSDIR} +.endif + CFLAGS:= ${CFLAGS:S/-O2/-O/} -Wno-write-strings post-patch: --- sysutils_smartmontools.patch ends here --- ______________________________________________________________________ This email has been scanned and certified safe by SpammerTrap(r). For Information please see http://www.spammertrap.com/ ______________________________________________________________________ >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120303202940.2BFBD1D40D>