From owner-freebsd-current  Mon Nov 25 10:46: 4 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9A0CD37B404; Mon, 25 Nov 2002 10:46:02 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2A43143E88; Mon, 25 Nov 2002 10:46:02 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from melange (melange.errno.com [66.127.85.82])
	(authenticated bits=0)
	by ebb.errno.com (8.12.5/8.12.1) with ESMTP id gAPIk09i020907
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Mon, 25 Nov 2002 10:46:01 -0800 (PST)?g
	(envelope-from sam@errno.com)œ
X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange
Message-ID: <235101c294b2$e66ce160$52557f42@errno.com>
From: "Sam Leffler" <sam@errno.com>
To: "Robert Watson" <rwatson@FreeBSD.ORG>
Cc: "Andrew Gallatin" <gallatin@cs.duke.edu>,
	"Luigi Rizzo" <rizzo@icir.org>, <current@FreeBSD.ORG>
References: <Pine.NEB.3.96L.1021125133654.42342C-100000@fledge.watson.org>
Subject: Re: mbuf header bloat ?
Date: Mon, 25 Nov 2002 10:46:00 -0800
Organization: Errno Consulting
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4807.1700
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

> > I don't see this problem; looutput looks to do the right thing.  FWIW
I've
> > passed mbufs w/ mtags through the loopback interface.
>
> This refers specifically to the following code snippet:
>
>         if (m && m->m_next != NULL && m->m_pkthdr.len < MCLBYTES) {
>                 struct mbuf *n;
>
>                 MGETHDR(n, M_DONTWAIT, MT_HEADER);
>                 if (!n)
>                         goto contiguousfail;
>                 MCLGET(n, M_DONTWAIT);
>                 if (! (n->m_flags & M_EXT)) {
>                         m_freem(n);
>                         goto contiguousfail;
>                 }
>
>                 m_copydata(m, 0, m->m_pkthdr.len, mtod(n, caddr_t));
>                 n->m_pkthdr = m->m_pkthdr;
>                 n->m_len = m->m_pkthdr.len;
>                 n->m_pkthdr.aux = m->m_pkthdr.aux;
>                 m->m_pkthdr.aux = (struct mbuf *)NULL;
>                 m_freem(m);
>                 m = n;
>         }
>

Something is wrong with your tree:

ebb% grep aux ../sys/mbuf.h
ebb%

The above code is correct in the repo as is the m_getcl code.

    Sam


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message