From owner-svn-src-head@FreeBSD.ORG Thu Jul 10 13:28:18 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 774F8ABC; Thu, 10 Jul 2014 13:28:18 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 026052AF0; Thu, 10 Jul 2014 13:28:17 +0000 (UTC) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s6ADSDew053805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Jul 2014 16:28:13 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s6ADSDew053805 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id s6ADSDfh053804; Thu, 10 Jul 2014 16:28:13 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 10 Jul 2014 16:28:13 +0300 From: Konstantin Belousov To: Baptiste Daroussin Subject: Re: svn commit: r268493 - head/lib/libfetch Message-ID: <20140710132813.GQ93733@kib.kiev.ua> References: <201407101304.s6AD4rne079137@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3WNG/pnnEPQXt+KF" Content-Disposition: inline In-Reply-To: <201407101304.s6AD4rne079137@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jul 2014 13:28:18 -0000 --3WNG/pnnEPQXt+KF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 10, 2014 at 01:04:53PM +0000, Baptiste Daroussin wrote: > Author: bapt > Date: Thu Jul 10 13:04:52 2014 > New Revision: 268493 > URL: http://svnweb.freebsd.org/changeset/base/268493 >=20 > Log: > Support EAGAIN in fetch_writev > =20 > Reviewed by: des > Approved by: des >=20 > Modified: > head/lib/libfetch/common.c >=20 > Modified: head/lib/libfetch/common.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libfetch/common.c Thu Jul 10 12:41:58 2014 (r268492) > +++ head/lib/libfetch/common.c Thu Jul 10 13:04:52 2014 (r268493) > @@ -1110,6 +1110,8 @@ fetch_writev(conn_t *conn, struct iovec=20 > errno =3D 0; > pfd.revents =3D 0; > if (poll(&pfd, 1, deltams) < 0) { > + if (errno =3D=3D EAGAIN) > + continue; > if (errno =3D=3D EINTR && fetchRestartCalls) > continue; > return (-1); How is this error possible ? poll(2) converts EAGAIN from seltdwait(9) to no error. --3WNG/pnnEPQXt+KF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTvpTsAAoJEJDCuSvBvK1BOhEP/1QQls2vv02DQTvOgl/eKkON EySdCYrMqQJ3HtyBNAoMZU2E0vuy3YdSVq8Y+n/fiZ2vc5cqQj9pLVJgWT4pz/ub WtWoxJBRqKgw5XTORVndgmE/2MAIi9jS2nt1Hn2P1IqT39YrHYYMPhMoKlu2Lofo rs7jr7qHMfnY4FszTL6vqIDfSLipKv8nBybgoAEYylG2oFTHlSR8g34LBArOf3pZ iZq93CLH5gkFaQngTDEE1XVE2T9sRshxNPUoJxtcTuqo80RIKD3eq2pew9EYnQh6 vKFUteNy13ZdS03ruzzLo+NuxSKPxyCn83CVF4Noarj0z/Fq5c91JYBbB0V32Q1n vLw2kiqKKZrJwQPuoXUcCRvtezVuzqTvMhTL8ZoLR8PnvJlzmneV/i04ax0pCNJN bd6Y7JGIFK2BpS53WkkSrVNcMH0oC7vlxDtuO66DObDtw3JEWTV6rXGsgoaGWnYr AGxH49ESh5Yy9JXL9Z1aIG4bd/icXTE9X1+Sl76p8iiUrr3ZqCPMm3//dm16Iu2y aBlV0AqkVy8f/LILrrYGOvWZF7Twyj0sKZkVYCIY728YPI5V4pF7AWgya1/KmKCt FoDkzAB+eD7S1PTq5+O4HiIvXwSc9J/3DqaTbBKTV+/+AkeF3ILX7wxE7i47HGhQ kisrVFJxqIHvANV0KQua =hbef -----END PGP SIGNATURE----- --3WNG/pnnEPQXt+KF--