From nobody Sat Sep 23 00:12:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RsqMV3wYNz4thKs; Sat, 23 Sep 2023 00:12:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RsqMV3Wdpz3FKk; Sat, 23 Sep 2023 00:12:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695427942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=woq/OFwS4tKirLJB0VgaBh1rUAzBVjZoqQXIJFIakMY=; b=KmJDGlzC6RKBVh8wDvSddgG1QeI8DpSvsYHUCnbC0kNOgfCQIS5CDX3bG5BlGxdA4uMljS yXvVekcSaTIhhH+ewoiQ5FGBScWS0Z9MgrTlAwS0IyRrvb55uL/vIhD5C1UtJd5gNRo6VT 2KtC3oHAmd/4kh9tIhVZW0FL9xiJrQr6cMaQ2IMyZocmtEUnRol7NAtT54jC+n/iy+8/+N jIYiz91NFkOVD2xQCpU/UZ6jB0ZooqgfaEW9+Swtg98mgDpt0y4SK3ehqXbIMx9BtO27ut vmZBPuw+Si+NcnI3RKB9nrZ+iSHsSQBwlmfMGD3RQTplxNHmVEDO5bkuM1FN1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695427942; a=rsa-sha256; cv=none; b=iuqM9zBduftanR66S+UZRVHrhua2eEfG2+xh43G3caOG0yGQ1UbfQ/RXLDD3WwWcqK+yCw rUm6S9cp5vRRTd6qmddHENXu5i1ztsu0nkmdbsgUdmU4rp9iiODaQLKgE109kR+kxob0IQ n4gAlsOrkc/wrLyFPO+vmQowo8dh1h1qRYPp2K092g9uHe+axgRqYlG53sfklqQf6p75xn qv3VDJIZkHvs8rohBTARp40lOb98QJTtkEV5W+1IdyKayUxYX7F8zOvuMRrBE/rmX8r2w8 XL6u25Yi73Ap+nkJ2Ff1n4aNCzhnADkiLIv7CM9oeGr1S7quzjvmGt8SF4nxpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695427942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=woq/OFwS4tKirLJB0VgaBh1rUAzBVjZoqQXIJFIakMY=; b=qCIzqEPQY5oP1g0lBbfyftf0afCR5UmofwdtSrglVrzGtvlKi1h4b1I7TPCqbiyh55v3wM ZiCaY0dw/fCn+kW+3iA19fWXcHrqyJXSY3OrjAAZGKfhcRAoPl7EJgqhKoT0Mxz5GwbBoQ 7HjoXD4YRkF4g2QnWQUXXTxEgGYW7HU32QLMdkWLZfWkiOKOJgoU+nH+dP4rwgefvBD1fr zpuKzsCcuqpO+k8/VbS31GEbUZo18RI2YVw9iBKGC1QuIA8GGpcCHYf4lZ3OCgcSYDVIpO xZaVAGIyTS7S9cP0O69gaZhmY5JQu+Z/ARV2HW810oczx5FfpuQAWSFtlLBFzg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RsqMV2ZZCzjHL; Sat, 23 Sep 2023 00:12:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38N0CMsI092314; Sat, 23 Sep 2023 00:12:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38N0CMfo092311; Sat, 23 Sep 2023 00:12:22 GMT (envelope-from git) Date: Sat, 23 Sep 2023 00:12:22 GMT Message-Id: <202309230012.38N0CMfo092311@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: bb124a0f611a - main - vfs cache: retire dothits and dotdothits counters List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bb124a0f611a1288c8496e3b33494f23ba929ca1 Auto-Submitted: auto-generated The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=bb124a0f611a1288c8496e3b33494f23ba929ca1 commit bb124a0f611a1288c8496e3b33494f23ba929ca1 Author: Mateusz Guzik AuthorDate: 2023-09-23 00:08:49 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-23 00:08:49 +0000 vfs cache: retire dothits and dotdothits counters They demonstrate nothing, and in case of dotdot they are not even hits. This is just a count of lookups with "..", which are not worth mentioniong. --- sys/kern/vfs_cache.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 1edd8fad0e89..12b9f2d74641 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -530,8 +530,6 @@ STATNODE_ULONG(neg, numneg, "Number of negative cache entries"); STATNODE_ULONG(count, numcache, "Number of cache entries"); STATNODE_COUNTER(heldvnodes, numcachehv, "Number of namecache entries with vnodes held"); STATNODE_COUNTER(drops, numdrops, "Number of dropped entries due to reaching the limit"); -STATNODE_COUNTER(dothits, dothits, "Number of '.' hits"); -STATNODE_COUNTER(dotdothits, dotdothits, "Number of '..' hits"); STATNODE_COUNTER(miss, nummiss, "Number of cache misses"); STATNODE_COUNTER(misszap, nummisszap, "Number of cache misses we do not want to cache"); STATNODE_COUNTER(poszaps, numposzaps, @@ -1782,7 +1780,6 @@ cache_lookup_dot(struct vnode *dvp, struct vnode **vpp, struct componentname *cn int ltype; *vpp = dvp; - counter_u64_add(dothits, 1); SDT_PROBE3(vfs, namecache, lookup, hit, dvp, ".", *vpp); if (tsp != NULL) timespecclear(tsp); @@ -1827,7 +1824,6 @@ cache_lookup_dotdot(struct vnode *dvp, struct vnode **vpp, struct componentname return (0); } - counter_u64_add(dotdothits, 1); retry: dvlp = VP2VNODELOCK(dvp); mtx_lock(dvlp); @@ -5131,7 +5127,6 @@ cache_fplookup_dot(struct cache_fpl *fpl) fpl->tvp = fpl->dvp; fpl->tvp_seqc = fpl->dvp_seqc; - counter_u64_add(dothits, 1); SDT_PROBE3(vfs, namecache, lookup, hit, fpl->dvp, ".", fpl->dvp); error = 0; @@ -5220,7 +5215,6 @@ cache_fplookup_dotdot(struct cache_fpl *fpl) return (cache_fpl_aborted(fpl)); } - counter_u64_add(dotdothits, 1); return (0); }