Date: Mon, 12 Dec 2011 17:10:27 +0100 From: Attilio Rao <attilio@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: Kostik Belousov <kostikbel@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228433 - in head/sys: kern security/mac Message-ID: <CAJ-FndDJbrTT0u1Hz_0MLJiEq3G0qcq77jBqfttVeUgiR414=g@mail.gmail.com> In-Reply-To: <4EE5D574.9080303@FreeBSD.org> References: <201112121005.pBCA5Dar093711@svn.freebsd.org> <20111212101558.GK50300@deviant.kiev.zoral.com.ua> <4EE5D574.9080303@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/12/12 Andriy Gapon <avg@freebsd.org>: > on 12/12/2011 12:15 Kostik Belousov said the following: >> On Mon, Dec 12, 2011 at 10:05:13AM +0000, Andriy Gapon wrote: >>> Author: avg >>> Date: Mon Dec 12 10:05:13 2011 >>> New Revision: 228433 >>> URL: http://svn.freebsd.org/changeset/base/228433 >>> >>> Log: >>> =C2=A0 put sys/systm.h at its proper place or add it if missing >>> >>> =C2=A0 Reported by: =C2=A0 =C2=A0 =C2=A0 lstewart, tinderbox >>> =C2=A0 Pointyhat to: =C2=A0 =C2=A0 =C2=A0avg, attilio >>> =C2=A0 MFC after: 1 week >>> =C2=A0 MFC with: =C2=A0r228430 >>> >>> Modified: >>> =C2=A0 head/sys/kern/kern_sx.c >>> =C2=A0 head/sys/kern/vfs_cache.c >>> =C2=A0 head/sys/security/mac/mac_framework.c >>> =C2=A0 head/sys/security/mac/mac_priv.c >> It means that previously sx.h did not required systm.h and now it does ? >> Might be, you should move SCHEDULER_STOPPED and stop_scheduler declarati= ons >> into sys/lock.h ? >> > > Strictly speaking it's sys/lockstat.h that now requires systm.h. > I am not an expert in FreeBSD header file organization, so I will just fo= llow > whatever the experts advise. I think that we should revert this part of the patch and just fix dtrace_probe() for pollution, this way we get the same effect and avoid namespace pollution (and still improve the MFC situation). I'll make a patch available in the next hour. Attilio --=20 Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndDJbrTT0u1Hz_0MLJiEq3G0qcq77jBqfttVeUgiR414=g>