From owner-cvs-gnu Fri Mar 6 11:08:14 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA03005 for cvs-gnu-outgoing; Fri, 6 Mar 1998 11:08:14 -0800 (PST) (envelope-from owner-cvs-gnu) Received: from lsd.relcom.eu.net (ache@lsd.relcom.eu.net [193.125.27.73]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA02893; Fri, 6 Mar 1998 11:07:57 -0800 (PST) (envelope-from ache@lsd.relcom.eu.net) Received: (from ache@localhost) by lsd.relcom.eu.net (8.8.8/8.8.8) id WAA10847; Fri, 6 Mar 1998 22:07:52 +0300 (MSK) (envelope-from ache) Message-ID: <19980306220751.23226@nagual.pp.ru> Date: Fri, 6 Mar 1998 22:07:51 +0300 From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= To: Guido van Rooij , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-gnu@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/usr.bin/sort sort.c Mail-Followup-To: Guido van Rooij , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-gnu@FreeBSD.ORG References: <199803061900.LAA05916@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <199803061900.LAA05916@freefall.freebsd.org>; from guido@FreeBSD.ORG on Fri, Mar 06, 1998 at 11:00:27AM -0800 Organization: Biomechanoid Sender: owner-cvs-gnu@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Fri, Mar 06, 1998 at 11:00:27AM -0800, Guido van Rooij wrote: > guido 1998/03/06 11:00:27 PST > > Modified files: > gnu/usr.bin/sort sort.c > Log: > Open temporary files with O_EXCL. > Obtained from:bugtraq This change cause sort fails if someone makes file with the same name. It means that anybody can stop root's sort in progress (f.e. valuable things sorted) or any user sort. Non-fixed sort allows more, of course, but such fix is half-dancing only. Better fix required. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/