From owner-freebsd-net@FreeBSD.ORG Tue Dec 27 17:46:57 2011 Return-Path: Delivered-To: net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA38C106566B; Tue, 27 Dec 2011 17:46:57 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 48D8F8FC15; Tue, 27 Dec 2011 17:46:57 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id pBRHkuZb030807; Tue, 27 Dec 2011 21:46:56 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id pBRHkuYg030806; Tue, 27 Dec 2011 21:46:56 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 27 Dec 2011 21:46:55 +0400 From: Gleb Smirnoff To: Ermal Lu?i Message-ID: <20111227174655.GS8035@glebius.int.ru> References: <201112221130.01823.jhb@freebsd.org> <20111227041728.GI8035@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Robert Watson , John Baldwin , net@FreeBSD.org Subject: Re: Transitioning if_addr_lock to an rwlock X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Dec 2011 17:46:57 -0000 On Tue, Dec 27, 2011 at 11:29:02AM +0100, Ermal Lu?i wrote: E> 2011/12/27 Gleb Smirnoff : E> > On Thu, Dec 22, 2011 at 11:30:01AM -0500, John Baldwin wrote: E> > J> You can find the patch for 8.x at E> > J> http://www.freebsd.org/~jhb/patches/if_addr_rwlock.patch E> > E> > Just my two pennies: for head/ patching if ip_carp.c should E> > be straightforward: E> > E> > 1) Using W in carp_alloc_if() and carp_free_if(). E> > 2) Using R everywhere else. E> > E> E> I would not say that is true! E> E> Look at this https://github.com/bsdperimeter/pfsense-tools/blob/master/patches/RELENG_8_1/carp_livelock_fixes.diff E> I already did this for carp on pfSense for 8.x and should be the same for HEAD. E> That has undergone testing and catching up where R vs W. Ermal, in head/ we already got new CARP implementation. -- Totus tuus, Glebius.