Date: Tue, 27 Dec 2011 21:46:55 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Ermal Lu?i <eri@FreeBSD.org> Cc: Robert Watson <rwatson@FreeBSD.org>, John Baldwin <jhb@FreeBSD.org>, net@FreeBSD.org Subject: Re: Transitioning if_addr_lock to an rwlock Message-ID: <20111227174655.GS8035@glebius.int.ru> In-Reply-To: <CAPBZQG1HvMJ_RnM1Fofidd=U7Ty7-2x7Csb9tnsQOSGtYENZRA@mail.gmail.com> References: <201112221130.01823.jhb@freebsd.org> <20111227041728.GI8035@FreeBSD.org> <CAPBZQG1HvMJ_RnM1Fofidd=U7Ty7-2x7Csb9tnsQOSGtYENZRA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 27, 2011 at 11:29:02AM +0100, Ermal Lu?i wrote: E> 2011/12/27 Gleb Smirnoff <glebius@freebsd.org>: E> > On Thu, Dec 22, 2011 at 11:30:01AM -0500, John Baldwin wrote: E> > J> You can find the patch for 8.x at E> > J> http://www.freebsd.org/~jhb/patches/if_addr_rwlock.patch E> > E> > Just my two pennies: for head/ patching if ip_carp.c should E> > be straightforward: E> > E> > 1) Using W in carp_alloc_if() and carp_free_if(). E> > 2) Using R everywhere else. E> > E> E> I would not say that is true! E> E> Look at this https://github.com/bsdperimeter/pfsense-tools/blob/master/patches/RELENG_8_1/carp_livelock_fixes.diff E> I already did this for carp on pfSense for 8.x and should be the same for HEAD. E> That has undergone testing and catching up where R vs W. Ermal, in head/ we already got new CARP implementation. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111227174655.GS8035>