From owner-freebsd-geom@FreeBSD.ORG  Fri Apr  6 14:26:42 2012
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 07CF81065670;
	Fri,  6 Apr 2012 14:26:42 +0000 (UTC)
	(envelope-from bengta@P142.sics.se)
Received: from sink.sics.se (sink.sics.se [193.10.64.88])
	by mx1.freebsd.org (Postfix) with ESMTP id 8078B8FC1A;
	Fri,  6 Apr 2012 14:26:41 +0000 (UTC)
Received: from P142.sics.se (h139n3-u-d1.ias.bredband.telia.com
	[90.228.197.139])
	by sink.sics.se (8.14.4/8.14.4) with ESMTP id q36DxF4g055237
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Fri, 6 Apr 2012 15:59:15 +0200 (CEST)
	(envelope-from bengta@P142.sics.se)
Received: from P142.sics.se (localhost [127.0.0.1])
	by P142.sics.se (8.14.5/8.14.4) with ESMTP id q36Dxhqu002227;
	Fri, 6 Apr 2012 15:59:43 +0200 (CEST)
	(envelope-from bengta@P142.sics.se)
Received: (from bengta@localhost)
	by P142.sics.se (8.14.5/8.14.5/Submit) id q36DxhDW002226;
	Fri, 6 Apr 2012 15:59:43 +0200 (CEST)
	(envelope-from bengta@P142.sics.se)
From: Bengt Ahlgren <bengta@sics.se>
To: "Andrey V. Elsukov" <ae@FreeBSD.org>
In-Reply-To: <4F7E72D7.6040501@FreeBSD.org> (Andrey V. Elsukov's message of
	"Fri, 06 Apr 2012 08:36:39 +0400")
References: <201204052210.q35MA5gt065889@freefall.freebsd.org>
	<4F7E72D7.6040501@FreeBSD.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix)
Date: Fri, 06 Apr 2012 15:59:43 +0200
Message-ID: <uh7k41tt0z4.fsf@P142.sics.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: freebsd-geom@FreeBSD.org
Subject: Re: bin/165789: bsdlabel(8): partition c doesn't cover the whole
	unit!
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2012 14:26:42 -0000

"Andrey V. Elsukov" <ae@FreeBSD.org> writes:

> On 06.04.2012 2:10, Bengt Ahlgren wrote:
>>  bsdlabel: partition c doesn't cover the whole unit!
>>  bsdlabel: An incorrect partition c may cause problems for standard system utilities
>>  
>>  I added a printout of the value bsdlabel compares with:
>>  
>>  bsdlabel: partition c doesn't cover the whole unit! 1953525168
>>  
>>  This number corresponds to the size of the whole disk, not the size of
>>  the slice, so lp->d_secperunit is not the right variable to use, or is
>>  incorrectly set.
>>  
>>  Finally, I stepped back to r220455 (in stable/8).  That version of
>>  bsdlabel did not complain, so it seems that r227564 by ae (cc:d) is
>>  causing, or making visible, this problem.
>
> Hi,
>
> Thank you for your report. Yes, r227564 has made visible a known sysinstall's bug.
> GEOM_PART_BSD already has quirk that automatically fixes it, can you try attached patch?

The patch does fix the issue with bsdlabel - thanks!

I am however curious to why you refer to a sysinstall bug.  I did not
use sysinstall to create the partitions.

Bengt