Date: Thu, 20 Dec 2018 12:54:52 -1000 (-10) From: Gerald Pfeifer <gerald@pfeifer.com> To: Yuri Victorovich <yuri@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Tobias Kortkamp <tobik@freebsd.org> Subject: Re: svn commit: r487864 - head/misc/gnuit Message-ID: <alpine.LSU.2.21.1812201157030.3662@anthias.pfeifer.com> In-Reply-To: <201812200847.wBK8lMfl071532@repo.freebsd.org> References: <201812200847.wBK8lMfl071532@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 20 Dec 2018, Yuri Victorovich wrote:
> Log:
> misc/gnuit: Unbreak by adding a missing file to plist
This was not the proper way to address this, Yuri.
I would have appreciated getting a heads-up, but in any case...
> Modified: head/misc/gnuit/pkg-plist
:
> +share/info/gnuit.info
...manually adding .info files to pkg-plist is not the way to go,
and hasn't been for more than fifteen years:
r86250 | kris | 2003-08-04 01:17:39 +0000 (Mo., 04 Aug. 2003) | 14 lines
:
* Add support for semi-automatic processing of GNU info files; they
should be listed in the INFO variable (without the trailing .info),
and appropriate installation/deinstallation code will be automatically
added to the temporary pkg-plist before package registration. [3]
Submitted by: arved [1][2], gerald [3]
PR: ports/54782 [1][2], ports/54883 [3]
> Reviewed by: portmgr (unbreak)
Who on portmgr reviewed (let alone approved) this commit?
Looking at Tobias' response, this isn't the only port that requires
fixing up after your commit.
I took care of misc/gnuit per the below (which now took me thrice as
long overall than a simple heads-up would have).
Gerald
======== snip ========
Author: gerald
Date: Thu Dec 20 22:47:20 2018
New Revision: 487928
URL: https://svnweb.freebsd.org/changeset/ports/487928
Log:
Fix up after revision r487864 which added a .info file to pkg-plist
instead of using the INFO= facility of the Ports Collection infrastructure.
Since the .info file is now packaged, bump PORTREVISION.
Modified:
head/misc/gnuit/Makefile
head/misc/gnuit/pkg-plist
Modified: head/misc/gnuit/Makefile
==============================================================================
--- head/misc/gnuit/Makefile Thu Dec 20 22:45:26 2018 (r487927)
+++ head/misc/gnuit/Makefile Thu Dec 20 22:47:20 2018 (r487928)
@@ -3,7 +3,7 @@
PORTNAME= gnuit
PORTVERSION= 4.9.5
-PORTREVISION= 3
+PORTREVISION= 4
CATEGORIES= misc
MASTER_SITES= GNU
@@ -16,6 +16,7 @@ LICENSE_COMB= multi
USES= ncurses
GNU_CONFIGURE= YES
CONFIGURE_ARGS= --disable-transition
+INFO= gnuit
post-install:
# Clean stage from orphans.
Modified: head/misc/gnuit/pkg-plist
==============================================================================
--- head/misc/gnuit/pkg-plist Thu Dec 20 22:45:26 2018 (r487927)
+++ head/misc/gnuit/pkg-plist Thu Dec 20 22:47:20 2018 (r487928)
@@ -68,5 +68,4 @@ man/man1/gitrgrep.1.gz
man/man1/gitunpack.1.gz
man/man1/gitview.1.gz
man/man1/gitwipe.1.gz
-share/info/gnuit.info
%%DOCSDIR%%/gnuit.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1812201157030.3662>