From owner-svn-ports-all@freebsd.org Fri Jul 27 09:04:31 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46CC51043A28; Fri, 27 Jul 2018 09:04:31 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (unknown [IPv6:2a01:4f8:d12:604::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 943BE8C05D; Fri, 27 Jul 2018 09:04:30 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id w6R94Jlw071321 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Jul 2018 11:04:19 +0200 (CEST) (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: yuri@FreeBSD.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id w6R948pB041394 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 27 Jul 2018 16:04:08 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: svn commit: r475418 - head/science/xcrysden To: Yuri Victorovich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201807270850.w6R8ogid015831@repo.freebsd.org> From: Eugene Grosbein Message-ID: <5B5AE004.8020100@grosbein.net> Date: Fri, 27 Jul 2018 16:04:04 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <201807270850.w6R8ogid015831@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.2 required=5.0 tests=BAYES_00, LOCAL_FROM, RDNS_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.1 X-Spam-Report: * -0.0 SPF_PASS SPF: sender matches SPF record * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 2.6 LOCAL_FROM From my domains * 1.9 RDNS_NONE Delivered to internal network by a host with no rDNS X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 09:04:31 -0000 27.07.2018 15:50, Yuri Victorovich wrote: > Author: yuri > Date: Fri Jul 27 08:50:41 2018 > New Revision: 475418 > URL: https://svnweb.freebsd.org/changeset/ports/475418 > > Log: > science/xcrysden: Add missing runtime dependencies > > Modified: > head/science/xcrysden/Makefile > > Modified: head/science/xcrysden/Makefile > ============================================================================== > --- head/science/xcrysden/Makefile Fri Jul 27 08:04:49 2018 (r475417) > +++ head/science/xcrysden/Makefile Fri Jul 27 08:50:41 2018 (r475418) > @@ -2,6 +2,7 @@ > > PORTNAME= xcrysden > DISTVERSION= 1.5.60 > +PORTREVISION= 1 > CATEGORIES= science > MASTER_SITES= http://www.xcrysden.org/download/ > > @@ -12,7 +13,11 @@ LICENSE= GPLv2 > LICENSE_FILE= ${WRKSRC}/COPYING > > LIB_DEPENDS= libfftw3.so:math/fftw3 > -RUN_DEPENDS= bwidget>0:x11-toolkits/bwidget > +RUN_DEPENDS= bwidget>0:x11-toolkits/bwidget \ > + babel:science/openbabel \ > + convert:graphics/ImageMagick \ > + ppmtompeg:graphics/netpbm \ > + xwd:x11/xwd > > USES= fortran gmake localbase:ldflags tcl tk > USE_GL= gl glu > If you are doing this just because "make" in port directory reports allegedly missing run-time dependencies, please stop adding them. It misgudes you showing recursive dependencies and recursive dependencies should never be added to leaf port but to intermidiate port considering possible conditional builds, options etc. This should be done with care, including needed minimal version numbers according to requirements documented upstream.