Date: Wed, 04 Jan 2017 16:18:20 -0600 From: Mark Felder <feld@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, "Sunpoet Po-Chuan Hsieh" <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r430581 - head/dns/dnscrypt-proxy Message-ID: <1483568300.3959813.837597441.418E927F@webmail.messagingengine.com> In-Reply-To: <a3d669ae-b9b7-080a-fc90-bbe2a34ade02@FreeBSD.org> References: <201701041738.v04HcdNM006335@repo.freebsd.org> <CAMHz58Rjdk4%2BWOC1b0tk0KOpLjwrqFug8Ff903AMxKv3JFkXkg@mail.gmail.com> <a3d669ae-b9b7-080a-fc90-bbe2a34ade02@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 4, 2017, at 16:13, Mathieu Arnold wrote: > Le 04/01/2017 =C3=A0 19:21, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > > > > +USE_LDCONFIG=3D yes > > + > > > > > > Hello Mark, > > > > This line seems to be incorrect. > > > > from /usr/ports/Mk/bsd.port.mk <http://bsd.port.mk>: > > # USE_LDCONFIG - If set to "yes", this adds ${PREFIX}/lib to the list = of > > # directories to be searched for > > shared libraries. > > # Otherwise, this is a list of > > directories to be added to that > > # list. The directory names are written= to > > #=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 > > ${LOCALBASE}/libdata/ldconfig/${PKGBASE} which is then > > # used by the ldconfig startup script. > > > > USE_LDCONFIG is only needed when PLUGINS is enabled. > > Besides, PLUGINS installs shared objects to PREFIX/lib/dnscrypt-proxy. > > I think the correct one is: > > PLUGINS_USE=3DLDCONFIG=3D${PREFIX}/lib/dnscrypt-proxy > > >=20 > In any case, I don't think USE_LDCONFIG is needed here, the software > will know where to load its plugins from. >=20 Funny, right as I was finish testing and committing his suggested changes you make this point... --=20 Mark Felder ports-secteam & portmgr member feld@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1483568300.3959813.837597441.418E927F>