From owner-svn-src-all@freebsd.org Fri Apr 15 23:00:44 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0FD5BAEE8E3; Fri, 15 Apr 2016 23:00:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E6389178D; Fri, 15 Apr 2016 23:00:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 7F28AB918; Fri, 15 Apr 2016 19:00:42 -0400 (EDT) From: John Baldwin To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298026 - head/sys/cam/scsi Date: Fri, 15 Apr 2016 15:25:06 -0700 Message-ID: <1915510.JYiahWoHr4@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201604150309.u3F39wPb047755@repo.freebsd.org> References: <201604150309.u3F39wPb047755@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 15 Apr 2016 19:00:42 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 23:00:44 -0000 On Friday, April 15, 2016 03:09:58 AM Warner Losh wrote: > Author: imp > Date: Fri Apr 15 03:09:58 2016 > New Revision: 298026 > URL: https://svnweb.freebsd.org/changeset/base/298026 > > Log: > Use the new TUNABLE_INT64 to match the type of sbintime_t. This seems odd and possibly broken. The tunable should accept the same values in the same units as the sysctl (e.g. milliseconds here, not a 64-bit fixed-point sbintime_t). Also, in HEAD if you just add CTLFLAG_TUN you will get that for free I think (as the sysctl code in HEAD will parse the integer from the tunable and pass it to your SYSCTL_PROC handler during boot). -- John Baldwin