From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Mar 20 17:52:51 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E446C16A4CE; Sat, 20 Mar 2004 17:52:51 -0800 (PST)
Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B879643D1D; Sat, 20 Mar 2004 17:52:51 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(91284762d0ec27d672c06242297c0358@adsl-67-119-53-203.dsl.lsan03.pacbell.net
	[67.119.53.203])
	by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i2L1qpaG010102;
	Sat, 20 Mar 2004 17:52:51 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 13AAE52148; Sat, 20 Mar 2004 17:52:51 -0800 (PST)
Date: Sat, 20 Mar 2004 17:52:50 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Edwin Groothuis <edwin@FreeBSD.org>
Message-ID: <20040321015250.GA42295@xor.obsecurity.org>
References: <200403100544.i2A5i65p044760@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200403100544.i2A5i65p044760@freefall.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: freebsd-ports-bugs@FreeBSD.org
cc: portmgr@FreeBSD.org
Subject: 
	Re: ports/64029: [PATCH] _CKSUMFILES vs CKSUMFILES, with DIST_SUBDIR
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Mar 2004 01:52:52 -0000

On Tue, Mar 09, 2004 at 09:44:06PM -0800, Edwin Groothuis wrote:
> Synopsis: [PATCH] _CKSUMFILES vs CKSUMFILES, with DIST_SUBDIR
> 
> Responsible-Changed-From-To: freebsd-ports-bugs->portmgr
> Responsible-Changed-By: edwin
> Responsible-Changed-When: Tue Mar 9 21:43:45 PST 2004
> Responsible-Changed-Why: 
> Portmgr territoriy
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=64029

As a matter of style, I'd prefer to use !empty(IGNOREFILES) etc
instead of explicitly testing against the null string.

Kris