Date: Mon, 28 Oct 2002 16:37:39 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: current@FreeBSD.org, Nate Lawson <nate@root.org>, Terry Lambert <tlambert2@mindspring.com> Subject: Re: libgtop port and v_tag changes Message-ID: <XFMail.20021028163739.jhb@FreeBSD.org> In-Reply-To: <1035840812.328.3.camel@gyros.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28-Oct-2002 Joe Marcus Clarke wrote: > On Mon, 2002-10-28 at 16:27, John Baldwin wrote: >> >> On 28-Oct-2002 Terry Lambert wrote: >> > John Baldwin wrote: >> >> I mean, do you know what libgtop is used for? It's used to draw >> >> little applets that display load averages and other silly system >> >> monitor stuff in small spaces in GUI's. It seems to work quite >> >> happily w/o any inode numbers or dev_t's for non-UFS filesystems. >> >> I just don't see why some little graphical applet displaying a load >> >> average or disk usage or ethernet device usage needs the inode >> >> number and dev_t of vnode's in the kernel. I mean, geez. >> > >> > To build little applets that activate a flashing red light when >> > certain files are written? >> >> Why do you need the inode number to do that. Just kqueue on the >> file itself using a regular fd, and in that case you can stat(2) >> the file if you really need the i-node number. You don't need >> to use libkvm to actually go read the kernel to find this info! > > You're probably right. But without waiting to re-architect libgtop, I > think the immediate problem needs to be fixed. Shall I just commit my > original patch that uses libkvm? Use v_cachedid and v_cachedfs for all VREG vnodes. Then you don't need to even go near v_tag. This is fewer kvm_read()'s. If stable has the v_cachedid then it should be using that instead of reading in UFS inodes as well. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021028163739.jhb>