From owner-svn-ports-head@freebsd.org Sat May 21 11:33:47 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 448E7B44556; Sat, 21 May 2016 11:33:47 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7BE421CC9; Sat, 21 May 2016 11:33:46 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.1.21] (176.red-83-34-249.dynamicip.rima-tde.net [83.34.249.176]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 2367C43CDD; Sat, 21 May 2016 06:33:37 -0500 (CDT) Subject: Re: svn commit: r415078 - in head: . Mk To: Alexey Dokuchaev , Ed Maste References: <201605121820.u4CIKROJ004026@repo.freebsd.org> <20160513160151.GA30219@FreeBSD.org> <20160513182837.GF49383@ivaldir.etoilebsd.net> <20160513201919.GA48945@FreeBSD.org> <20160519122306.GA24015@FreeBSD.org> <20160521112728.GA624@FreeBSD.org> Cc: Baptiste Daroussin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org From: John Marino Message-ID: <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st> Date: Sat, 21 May 2016 13:33:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160521112728.GA624@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 May 2016 11:33:47 -0000 On 5/21/2016 1:27 PM, Alexey Dokuchaev wrote: > On Thu, May 19, 2016 at 12:23:06PM +0000, Alexey Dokuchaev wrote: >> ... >> I'm still not convinced though, sorry. Ports tree can be obtained by >> a number of means, but this new ugly TIMESTAMP thingy is added for a >> very specific usecase, and there should be no problem to require that >> for that particular usecase, exported ports tree must have its files' >> mtimes correctly set. (If svn/git/hg are not setting right mtimes on >> export, they should be fixed.) It looks more like quick'n'dirty hack >> rather than thoroughly thought-out solution. > > Given lack of replies, I guess I'd have to elaborate a bit on problems with > TIMESTAMP and why I'm against it. > > 1. It does not line up with distinfo format. This file contains certain > properties for each distfile a port requires, namely SIZE() and SHA256(), > which are used to verify their integrity. Notice that distinfo may list > several distfiles, and both SIZE() and SHA256() are essentially functions > of a particular distfile. > > Introducing TIMESTAMP breaks this logic, as it's not attached to anything. > Which distfile does it refer to? If it supposed to be bumped every time > distinfo changes, why not simply use max(m in mtime(distfiles)) if there > is (or rather, you *believe* there is) a problem with mtime(distinfo)? > > 2. It is not needed even if ports repo is obtained as tarball: svn/git/hg > all correctly set mtimes on files ("svn export", "hg/git archive"). If > users are tarring their checked out copy they're doing it wrong and should > be instructed how to export repositories correctly. > > Putting TIMESTAMP might be easier than writing proper documentation, but > that's not an excuse good enough for FreeBSD. Please reconsider. Maybe it could/should be implemented as a makefile variable instead? e.g. REP_TIMESTAMP= Just a suggestion. I don't disagree with you.