From owner-cvs-all Mon May 8 8:32:16 2000 Delivered-To: cvs-all@freebsd.org Received: from florence.pavilion.net (florence.pavilion.net [212.74.0.25]) by hub.freebsd.org (Postfix) with ESMTP id 8F3BA37BB91; Mon, 8 May 2000 08:32:08 -0700 (PDT) (envelope-from joe@pavilion.net) Received: from genius.systems.pavilion.net (postfix@genius.systems.pavilion.net [212.74.1.100]) by florence.pavilion.net (8.9.3/8.8.8) with ESMTP id QAA35313; Mon, 8 May 2000 16:32:06 +0100 (BST) (envelope-from joe@pavilion.net) Received: by genius.systems.pavilion.net (Postfix, from userid 100) id 924813C2; Mon, 8 May 2000 16:32:33 +0100 (BST) Date: Mon, 8 May 2000 16:32:33 +0100 From: Joe Karthauser To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chflags chflags.c [Heads up?] Message-ID: <20000508163233.Q52738@pavilion.net> References: <20000505202851.A20115@pavilion.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: ; from bde@zeta.org.au on Tue, May 09, 2000 at 12:42:48AM +1000 X-NCC-RegID: uk.pavilion Organisation: Pavilion Internet plc, Lees House, 21-23 Dyke Road, Brighton, England Phone: +44-845-333-5000 Fax: +44-845-333-5001 Mobile: +44-403-596893 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, May 09, 2000 at 12:42:48AM +1000, Bruce Evans wrote: > On Fri, 5 May 2000, Joe Karthauser wrote: > > > I only received one reply to this so I'm guessing that no-one else minds. > > [I know that we've all been preoccupied with restructuring documents ;)] > > > > It's been suggested the {g|s}etflagsbyname is a better set of > > function names, and I'm inclined to agree. I'm going to commit > > this next week, unless there are serious objections in advance. > > getflagsbyname() is a much worse name. getflags() gets a string > representing the flags from the flags, i.e., it gets non-flags by number. > > "flags" is too generic. I would prefer names like fileflagstostr() > and strtofileflags(), but shorter. Hmm, hard isn't it. How much shorter would make sense. fflagstostr? fflagstos fftos? > If the names are changed, then the broken interfaces should be fixed: > 1) getflags() returns the string in a static buffer. > 2) The "def" arg for getflags() is too specialized for ls. The caller > can easily translate from "" to whatever it wants to print if no > flags are set. (ls prints "-" and mtree prints "none".) I've already fixed these, but not committed yet. Joe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message