Date: Fri, 15 Jun 2007 22:30:34 +0400 From: "Andrew Pantyukhin" <sat@FreeBSD.org> To: "Alexey Dokuchaev" <danfe@freebsd.org>, cvs-all@freebsd.org, cvs-ports@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/graphics/sng Makefile pkg-descr Message-ID: <cb5206420706151130v7a5e687g31cfeac49f2ca1ab@mail.gmail.com> In-Reply-To: <20070615180818.EEBAE16A484@hub.freebsd.org> References: <200706151800.l5FI0BZD087745@repoman.freebsd.org> <20070615180818.EEBAE16A484@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/15/07, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> danfe 2007-06-15 18:00:11 UTC
>
> FreeBSD ports repository
>
> Modified files:
> graphics/sng Makefile pkg-descr
> Log:
> - Fix the build with recent GCC [1]
> - Correctly assign RUN_DEPENDS
> - Minor indentation nit in Makefile
> - Kill EOL space in pkg-descr
>
> Reported by: pointyhat (logs) [1]
>
> Revision Changes Path
> 1.13 +3 -2 ports/graphics/sng/Makefile
> 1.2 +1 -1 ports/graphics/sng/pkg-descr
> _______________________________________________
> pre-patch:
> @${REINPLACE_CMD} -e 's|-static||g' ${WRKSRC}/Makefile.in
> + @${REINPLACE_CMD} -e '33,34s|^static ||' ${WRKSRC}/sngd.c
I'd warn you against these numbered sed substitutions.
For one, they're hard to maintain. They also can cause
silent damage to sources which is very hard to track.
In this very case, it use this:
'/^static png_/s|^static ||'
Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cb5206420706151130v7a5e687g31cfeac49f2ca1ab>