From owner-svn-src-all@freebsd.org Sat Jul 11 16:26:43 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 911D09992D7 for ; Sat, 11 Jul 2015 16:26:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62D3E1EC8 for ; Sat, 11 Jul 2015 16:26:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by padck2 with SMTP id ck2so19217601pad.0 for ; Sat, 11 Jul 2015 09:26:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=LqQYmJRYrX5Lxg91SFhUPmP/8Z5eGmTvVhbwWyh0Wwc=; b=Y0HxR4rWuPrbq3omUCO5+TWdFJK2xJEJ3cqQSh4I6aXZDE74IMiqB97BYkmjvHDDGG Q31CE6uzDIo3mO9DMeqV3SEtGJuXuzTXwToCGnLEQVOS6F/Re3UattoNJ8Qm7eKCd1Qz xGb3l4TG1cq9GVWUl/LXbe4uike6OjRScx7ziZRc1wYLs+xI+XM88Ios/r2Uq1flA7SG Sk1teEaa+FEzNSqNwoyPJPbUJLn5e1Um3E9Y4/YJ24XWfjN/oPEBV8uTJTC/avGZih2o MF5Q38BYf9NYR3+nVo6vc6O/cbuewcuRoLWPRXTLOQdrztbi0P3biVBb1YCsexu7oU3v e9Cg== X-Gm-Message-State: ALoCoQl949KSMF3h4hrsGr4lQpPVmMYCO5CPZ1kh+YjY65IhxgcTFLX5KmB20jNmAkrZm9NPEZ9C X-Received: by 10.70.103.70 with SMTP id fu6mr53958914pdb.22.1436631995771; Sat, 11 Jul 2015 09:26:35 -0700 (PDT) Received: from [10.64.26.138] ([69.53.236.236]) by smtp.gmail.com with ESMTPSA id je4sm12989574pbb.17.2015.07.11.09.26.34 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 11 Jul 2015 09:26:35 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r285366 - in head: lib/libmd sys/crypto/sha2 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: multipart/signed; boundary="Apple-Mail=_9DEE4A8F-3E1B-40C5-BAF5-D815EF466111"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Warner Losh In-Reply-To: Date: Sat, 11 Jul 2015 10:26:37 -0600 Cc: John-Mark Gurney , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <34F75D0D-33F1-4D4F-81E5-A1DA7664868C@bsdimp.com> References: <201507110312.t6B3CZBv081280@repo.freebsd.org> <20150711080439.GD8523@funkthat.com> <20150711142920.GE8523@funkthat.com> To: Craig Rodrigues X-Mailer: Apple Mail (2.2102) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2015 16:26:43 -0000 --Apple-Mail=_9DEE4A8F-3E1B-40C5-BAF5-D815EF466111 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 11, 2015, at 8:33 AM, Craig Rodrigues = wrote: >=20 >=20 >=20 > On Sat, Jul 11, 2015 at 10:29 AM, John-Mark Gurney = wrote: > Craig Rodrigues wrote this message on Sat, Jul 11, 2015 at 10:16 = -0400: >=20 > > So it looks like _libmd_SHA256_File is not defined in the legacy > > library used during the bootstrap. >=20 > The closest I can see is that sha256hl.c (from mdXhl.c) is including > "sha256.h" with double quotes, and getting the wrong header file.. >=20 >=20 > Yes, I think you are right. >=20 > If I go to src/lib/libmd, and type: >=20 > make -V CFLAGS >=20 > I see: >=20 > -O2 -pipe -I/builds/FreeBSD_HEAD/lib/libmd -DWEAK_REFS -std=3Dgnu99 = -Qunused-arguments -fstack-protector -Wno-pointer-sign -Wno-empty-body = -Wno-string-plus-int -Wno-unused-const-variable = -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality = -Wno-unused-function -Wno-enum-conversion -Wno-switch -Wno-switch-enum = -Wno-knr-promoted-parameter -Wno-parentheses >=20 > After your change, there is no sha256.h file in the src/lib/libmd = directory, so the bootstrap stage > is picking up sha256.h from /usr/include , which causes problems. You=E2=80=99d be better off retaining sha256.h as an empty file, or = adding it to the legacy includes. But for some reason those aren=E2=80=99t= appearing on this command line (suggesting this is built after we=E2=80=99= re done with -legacy). If so, an empty file would likely cover many of = the sins here. I think you can add a CFLAGS.sha256hi.c=3D-E to get the intermediate = output of the pre-processor to see exactly where this file is coming = from. Or you can use the .depend file from the build to see where it was = picked up from (which might be easier). Unless you can resolve this quickly, I=E2=80=99d go with the blackout. Warner --Apple-Mail=_9DEE4A8F-3E1B-40C5-BAF5-D815EF466111 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVoUO9AAoJEGwc0Sh9sBEAlz8QAKiRcCiMe6yGhb/2ozXEqnJo zYV3LdrxYWAmxkO/pCjobWUzcaWQRSR9snqZTTIDbO/ACpgnXqKhOpS3OZzfScyZ 6HwQATjoGU+3zAej6ZlOO4ULkdKcM90oFWVyvEfk5mmpUbIn3O6eOEYUJk4LfvsP N8r+3mGykhZ5HRa/M2+l5ixsXWmDWGXWZxU5NHNuPSayho3B0ySvMZDfw9xblSku NL1UbBmjF0/PzreWdQjEf1u8BclO+YwUZx8mc2veHHnvqkwV9F9iu2+ndQeeqKDe JUWMSiTAO9iWNy4UI7iu/KK2dLNsa/e+Pz1Gs+dWTNWbj8EHedi3Cu46WEFbwbcc hvUiE4nmsCW3PHp0/8asUCSg4o64IFhuPAYbglY7gwdVTj7ztMFraACRY6AN1KgP Al8YFcNdOYWBOojbeFp02kPqQZGCQy5krzurqLhojU8IMETWNnwWZv6ynVg38Mkk YPgImCnoUcbJ3WlNCq6cO0dyC+SPHgU2J8JHrQVunTU+pfI2KBHBceSSJpL3lEf8 XTYRKL15m9lAPXkoDNMia7NLFlymsm6orWF+c3+MDPxEOYBLrLTgRUiJLjGiVhiz hvoeFmPKD3Q4y2xG3JgLc5UkMm71045Qi8Jlb4VtAdKJgvkBZsK9CnodLFMjhoAA YZE/JL7GO/AIsNxMAPNc =jgZg -----END PGP SIGNATURE----- --Apple-Mail=_9DEE4A8F-3E1B-40C5-BAF5-D815EF466111--