From owner-svn-src-all@freebsd.org Sun Oct 1 20:47:53 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3EAC3E2E405 for ; Sun, 1 Oct 2017 20:47:53 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2151F6E858 for ; Sun, 1 Oct 2017 20:47:52 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: cd6ae58a-a6e9-11e7-a937-4f970e858fdb X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id cd6ae58a-a6e9-11e7-a937-4f970e858fdb; Sun, 01 Oct 2017 20:47:56 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v91Klncs001816; Sun, 1 Oct 2017 14:47:49 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1506890869.22078.45.camel@freebsd.org> Subject: Re: svn commit: r324178 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua From: Ian Lepore To: "O. Hartmann" , Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sun, 01 Oct 2017 14:47:49 -0600 In-Reply-To: <20171001223707.574cde55@thor.intern.walstatt.dynvpn.de> References: <201710012012.v91KCUvU024559@repo.freebsd.org> <20171001223707.574cde55@thor.intern.walstatt.dynvpn.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 20:47:53 -0000 On Sun, 2017-10-01 at 22:37 +0200, O. Hartmann wrote: > Am Sun, 1 Oct 2017 20:12:30 +0000 (UTC) > Andriy Gapon schrieb: > > > > > Author: avg > > Date: Sun Oct  1 20:12:30 2017 > > New Revision: 324178 > > URL: https://svnweb.freebsd.org/changeset/base/324178 > > > > Log: > >   unbreak kernel builds on sparc64 and powerpc after r324163, ZFS > > Channel Programs > >    > >   The custom iscntrl() in ZFS Lua code expects a signed argumnet, > > so > >   remove the harmful cast. > >    > >   Reported by: ian > >   MFC after: 5 weeks > >   X-MFC with: r324163 > > > > Modified: > >   head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > > > > Modified: > > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > > =================================================================== > > =========== > > --- > > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > > Sun Oct  1 > > 19:52:47 2017 (r324177) +++ > > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > > Sun Oct  1 > > 20:12:30 2017 (r324178) @@ -867,7 +867,7 @@ static void > > addquoted (lua_State *L, > > luaL_Buffer *b, i luaL_addchar(b, '\\'); luaL_addchar(b, *s); > >      } > > -    else if (*s == '\0' || iscntrl(uchar(*s))) { > > +    else if (*s == '\0' || iscntrl(*s)) { > >        char buff[10]; > >        if (!isdigit(uchar(*(s+1)))) > >          sprintf(buff, "\\%d", (int)uchar(*s)); > > _______________________________________________ > > svn-src-head@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd. > > org" > The build of world fails for me with the error shown below: > > > [...] > Building /usr/obj/usr/src/cddl/lib/libzpool/lapi.o > --- lstrlib.o --- > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > :114:12: warning: > implicitly declaring library function 'tolower' with type 'int > (int)' [-Wimplicit-function-declaration] p[i] = tolower(uchar(s[i])); > ^ > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > :114:12: note: > include the header or explicitly provide a declaration for > 'tolower' > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > :127:12: > warning: implicitly declaring library function 'toupper' with type > 'int > (int)' [-Wimplicit-function-declaration] p[i] = toupper(uchar(s[i])); > > Also, removing the cast won't really be a fix on a platform that has default unsigned chars (which arm does, but arm doesn't use gcc; not sure about other platforms). -- Ian